Incorrect behaviour of `retries` in `network_retry_loop`

It seems that we increment `retries` for every loop iteration, even if the callback succeeded and there were no errors from the TG API: 

https://github.com/python-telegram-bot/python-telegram-bot/blob/c062712472a1476b3b6b082dddd8f35977b5ecf7/src/telegram/ext/_utils/networkloop.py#L149-L150

This conflicts with the logic of checking the number of retries done:

https://github.com/python-telegram-bot/python-telegram-bot/blob/c062712472a1476b3b6b082dddd8f35977b5ecf7/src/telegram/ext/_utils/networkloop.py#L131-L135

It also seems that we don't reset `retries = 0` when there are no errors returned.

	except TelegramError as telegram_exc:
	if on_err_cb:
	on_err_cb(telegram_exc)

	if max_retries < 0 or retries < max_retries:

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Incorrect behaviour of `retries` in `network_retry_loop` #4871

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

	finally:
	retries += 1

Incorrect behaviour of retries in network_retry_loop #4871

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Incorrect behaviour of `retries` in `network_retry_loop` #4871