From 6b8533d1c92f3368149f1200a6c842db9fda517e Mon Sep 17 00:00:00 2001 From: David Date: Fri, 5 Nov 2021 16:26:47 +0300 Subject: [PATCH 1/2] Added impementation of "prefallbacks" list. Imagine you have such CH: ``` ch = tg_ext.ConversationHandler( entry_points=[ tg_ext.CommandHandler("start", callback=lambda *args, **kwargs: 0)], states={ 0: [ tg_ext.MessageHandler(filters=tg_ext.Filters.text & ~Filters.regex("cancel"), callback=lambda *args, **kwargs: 1)], 1: [ tg_ext.MessageHandler(filters=tg_ext.Filters.text & ~Filters.regex("cancel"), callback=lambda *args, **kwargs: 2)], 2: [ tg_ext.MessageHandler(filters=tg_ext.Filters.text & ~Filters.regex("cancel"), callback=lambda *args, **kwargs: -1)], }, fallbacks=[ tg_ext.CommandHandler("cancel", callback=lambda *args, **kwargs: -1), ]) ``` Here you should apply `& ~Filter` for every handler in `states` to prevent catching a `cancel` command. But it can be easily avoided by adding list of handlers that should to trigger before any another update. --- telegram/ext/conversationhandler.py | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/telegram/ext/conversationhandler.py b/telegram/ext/conversationhandler.py index ba621fdeaa5..e82db205d88 100644 --- a/telegram/ext/conversationhandler.py +++ b/telegram/ext/conversationhandler.py @@ -190,6 +190,7 @@ class ConversationHandler(Handler[Update, CCT]): '_entry_points', '_states', '_fallbacks', + '_prefallbacks', '_allow_reentry', '_per_user', '_per_chat', @@ -217,6 +218,7 @@ class ConversationHandler(Handler[Update, CCT]): def __init__( self, entry_points: List[Handler[Update, CCT]], + prefallbacks: List[Handler[Update, CCT]], states: Dict[object, List[Handler[Update, CCT]]], fallbacks: List[Handler[Update, CCT]], allow_reentry: bool = False, @@ -232,6 +234,7 @@ def __init__( self.run_async = run_async self._entry_points = entry_points + self._prefallbacks = prefallbacks self._states = states self._fallbacks = fallbacks @@ -267,6 +270,7 @@ def __init__( all_handlers: List[Handler] = [] all_handlers.extend(entry_points) + all_handlers.extend(prefallbacks) all_handlers.extend(fallbacks) for state_handlers in states.values(): @@ -323,6 +327,18 @@ def entry_points(self) -> List[Handler]: @entry_points.setter def entry_points(self, value: object) -> NoReturn: raise ValueError('You can not assign a new value to entry_points after initialization.') + + @property + def prefallbacks(self) -> List[Handler]: + """List[:class:`telegram.ext.Handler`]: A list of handlers that might be used if + the user is in a conversation. This list of handlers will be processed before all the others handlers. + This list helps to reduce usage of "and not" filters. + """ + return self._prefallbacks + + @prefallbacks.setter + def prefallbacks(self, value: object) -> NoReturn: + raise ValueError('You can not assign a new value to prefallbacks after initialization.') @property def states(self) -> Dict[object, List[Handler]]: From 12e0dd8723dda09a25a93f6d3ff417b146467c9b Mon Sep 17 00:00:00 2001 From: David Date: Fri, 5 Nov 2021 16:51:50 +0300 Subject: [PATCH 2/2] Update conversationhandler.py Forget default value (`[]`) for `prefallbacks` --- telegram/ext/conversationhandler.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/telegram/ext/conversationhandler.py b/telegram/ext/conversationhandler.py index e82db205d88..2bdb4529841 100644 --- a/telegram/ext/conversationhandler.py +++ b/telegram/ext/conversationhandler.py @@ -218,9 +218,9 @@ class ConversationHandler(Handler[Update, CCT]): def __init__( self, entry_points: List[Handler[Update, CCT]], - prefallbacks: List[Handler[Update, CCT]], states: Dict[object, List[Handler[Update, CCT]]], fallbacks: List[Handler[Update, CCT]], + prefallbacks: List[Handler[Update, CCT]] = List(), allow_reentry: bool = False, per_chat: bool = True, per_user: bool = True, pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy