From 15cf488ba6b40e3ca8f8d117c6d2e8d4b0b72558 Mon Sep 17 00:00:00 2001
From: Victor Nova <lost@losttech.software>
Date: Thu, 5 Aug 2021 11:43:43 -0700
Subject: [PATCH] Names of .NET types (e.g. `str(__class__)`) changed to better
 support generic types

---
 CHANGELOG.md               |  1 +
 src/runtime/typemanager.cs | 72 +++++++++++++++++++++++++++++++-------
 2 files changed, 61 insertions(+), 12 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index da8f94774..387217c76 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -51,6 +51,7 @@ One must now either use enum members (e.g. `MyEnum.Option`), or use enum constru
 -   BREAKING: custom encoders are no longer called for instances of `System.Type`
 -   `PythonException.Restore` no longer clears `PythonException` instance.
 -   Replaced the old `__import__` hook hack with a PEP302-style Meta Path Loader
+-   BREAKING: Names of .NET types (e.g. `str(__class__)`) changed to better support generic types
 
 ### Fixed
 
diff --git a/src/runtime/typemanager.cs b/src/runtime/typemanager.cs
index 8d5600e4f..554858756 100644
--- a/src/runtime/typemanager.cs
+++ b/src/runtime/typemanager.cs
@@ -211,18 +211,7 @@ internal static unsafe PyType CreateType(Type impl)
 
         static PyType CreateClass(Type clrType)
         {
-            // Cleanup the type name to get rid of funny nested type names.
-            string name = $"clr.{clrType.FullName}";
-            int i = name.LastIndexOf('+');
-            if (i > -1)
-            {
-                name = name.Substring(i + 1);
-            }
-            i = name.LastIndexOf('.');
-            if (i > -1)
-            {
-                name = name.Substring(i + 1);
-            }
+            string name = GetPythonTypeName(clrType);
 
             using var baseTuple = GetBaseTypeTuple(clrType);
 
@@ -251,6 +240,65 @@ static PyType CreateClass(Type clrType)
             return pyType;
         }
 
+        static string GetPythonTypeName(Type clrType)
+        {
+            var result = new System.Text.StringBuilder();
+            GetPythonTypeName(clrType, target: result);
+            return result.ToString();
+        }
+
+        static void GetPythonTypeName(Type clrType, System.Text.StringBuilder target)
+        {
+            if (clrType.IsGenericType)
+            {
+                string fullName = clrType.GetGenericTypeDefinition().FullName;
+                int argCountIndex = fullName.LastIndexOf('`');
+                if (argCountIndex >= 0)
+                {
+                    string nonGenericFullName = fullName.Substring(0, argCountIndex);
+                    string nonGenericName = CleanupFullName(nonGenericFullName);
+                    target.Append(nonGenericName);
+
+                    var arguments = clrType.GetGenericArguments();
+                    target.Append('[');
+                    for (int argIndex = 0; argIndex < arguments.Length; argIndex++)
+                    {
+                        if (argIndex != 0)
+                        {
+                            target.Append(',');
+                        }
+
+                        GetPythonTypeName(arguments[argIndex], target);
+                    }
+
+                    target.Append(']');
+                    return;
+                }
+            }
+
+            string name = CleanupFullName(clrType.FullName);
+            target.Append(name);
+        }
+
+        static string CleanupFullName(string fullTypeName)
+        {
+            // Cleanup the type name to get rid of funny nested type names.
+            string name = "clr." + fullTypeName;
+            int i = name.LastIndexOf('+');
+            if (i > -1)
+            {
+                name = name.Substring(i + 1);
+            }
+
+            i = name.LastIndexOf('.');
+            if (i > -1)
+            {
+                name = name.Substring(i + 1);
+            }
+
+            return name;
+        }
+
         static BorrowedReference InitializeBases(PyType pyType, PyTuple baseTuple)
         {
             Debug.Assert(baseTuple.Length() > 0);

<!DOCTYPE html PUBLIC '-//W3C//DTD XHTML 1.0 Transitional//EN' 'http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd'>
<html xmlns='http://www.w3.org/1999/xhtml'>
<head>
<title>pFad - Phonifier reborn</title>
<meta http-equiv='Content-Type' content='text/html; charset=utf-8' />
</head>
<body>
<h1>Pfad - The Proxy pFad of &#169; 2024 Garber Painting. All rights reserved.</h1>


<!-- Disclaimer -->
<p>Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.</p>
<br>
<p>Alternative Proxies:</p><p><a href="http://rainy.clevelandohioweatherforecast.com/php-proxy/index.php?q=https://patch-diff.githubusercontent.com/raw/pythonnet/pythonnet/pull/1509.patch" target="_blank">Alternative Proxy</a></p><p><a href="http://rainy.clevelandohioweatherforecast.com/pFad/index.php?u=https://patch-diff.githubusercontent.com/raw/pythonnet/pythonnet/pull/1509.patch" target="_blank">pFad Proxy</a></p><p><a href="http://rainy.clevelandohioweatherforecast.com/pFad/v3index.php?u=https://patch-diff.githubusercontent.com/raw/pythonnet/pythonnet/pull/1509.patch" target="_blank">pFad v3 Proxy</a></p><p><a href="http://rainy.clevelandohioweatherforecast.com/pFad/v4index.php?u=https://patch-diff.githubusercontent.com/raw/pythonnet/pythonnet/pull/1509.patch" target="_blank">pFad v4 Proxy</a></p></body>
</html>