Remove app install auth decorator where possible

westphahl · westphahl · commit 473a62d0d171 · 2019-01-10T08:43:08.000+01:00
diff --git a/src/github3/checks.py b/src/github3/checks.py
@@ -216,7 +216,6 @@ def _update_attributes(self, suite):
     def _repr(self):
         return "<{s.class_name} [{s.id}:{s.status}]>".format(s=self)
 
-    @decorators.requires_app_installation_auth
     def rerequest(self):
         """Rerequest the check suite.
 
@@ -230,7 +229,6 @@ def rerequest(self):
             self._post(url, headers=CheckSuite.CUSTOM_HEADERS), 201, 404
         )
 
-    @decorators.requires_app_installation_auth
     def check_runs(self):
         """Retrieve the check runs for this suite.
 
@@ -346,7 +344,6 @@ def _update_attributes(self, output):
     def _repr(self):
         return "<{s.class_name} [{s.title}]>".format(s=self)
 
-    @decorators.requires_app_installation_auth
     def annotations(self):
         """Retrieve the annotations for a check run.
 
diff --git a/tests/unit/test_checks.py b/tests/unit/test_checks.py
@@ -10,7 +10,8 @@
 from .helper import (
     UnitAppInstallHelper,
     UnitRequiresAuthenticationHelper,
-    UnitIteratorAppInstHelper,
+    UnitHelper,
+    UnitIteratorHelper,
     create_url_helper,
     create_example_data_helper,
 )
@@ -58,7 +59,7 @@ def test_update_requires_auth(self):
             self.instance.update(name="newname")
 
 
-class TestCheckSuite(UnitAppInstallHelper):
+class TestCheckSuite(UnitHelper):
     described_class = CheckSuite
     example_data = check_suite_example_data()
 
@@ -82,7 +83,7 @@ def test_check_suite_types(self):
         )
 
 
-class TestCheckSuiteIteratorAppInstAuth(UnitIteratorAppInstHelper):
+class TestCheckSuiteIterator(UnitIteratorHelper):
     described_class = CheckSuite
     example_data = check_suite_example_data()
 
@@ -95,13 +96,3 @@ def test_check_runs(self):
             params={"per_page": 100},
             headers=CheckSuite.CUSTOM_HEADERS,
         )
-
-
-class TestCheckSuiteRequiresAuth(UnitRequiresAuthenticationHelper):
-    described_class = CheckSuite
-    example_data = check_suite_example_data()
-
-    def test_rerequest_requires_auth(self):
-        """Show rerequesting a run requires auth"""
-        with pytest.raises(GitHubException):
-            self.instance.rerequest()
