Add dateutil to parse timestamps

sigmavirus24 · sigmavirus24 · commit b273037a6907 · 2018-03-09T17:22:05.000-06:00
GitHub is inconsistent in the timestamps it returns for the issue import
API. strptime has a way of handling UTC offsets a format like -0600 but
not -06:00. There's no good way to handle that with the standard
library, so here we must add dateutil.
diff --git a/github3/models.py b/github3/models.py
@@ -2,18 +2,16 @@
 """This module provides the basic models used in github3.py."""
 from __future__ import unicode_literals
 
-from datetime import datetime
 from json import dumps, loads
 from logging import getLogger
 
+import dateutil.parser
 import requests
 from requests.compat import is_py2, urlparse
 
 from . import exceptions
 from .session import GitHubSession
-from .utils import UTC
 
-__timeformat__ = '%Y-%m-%dT%H:%M:%SZ'
 __logs__ = getLogger(__package__)
 
 
@@ -145,9 +143,7 @@ def _strptime(cls, time_str):
         :rtype: datetime or None
         """
         if time_str:
-            # Parse UTC string into naive datetime, then add timezone
-            dt = datetime.strptime(time_str, __timeformat__)
-            return dt.replace(tzinfo=UTC())
+            return dateutil.parser.parse(time_str)
         return None
 
     def __repr__(self):
diff --git a/github3/utils.py b/github3/utils.py
@@ -45,26 +45,6 @@ def timestamp_parameter(timestamp, allow_none=True):
     raise ValueError("Cannot accept type %s for timestamp" % type(timestamp))
 
 
-class UTC(datetime.tzinfo):
-
-    """Yet another UTC reimplementation, to avoid a dependency on pytz or
-    dateutil."""
-
-    ZERO = datetime.timedelta(0)
-
-    def __repr__(self):
-        return 'UTC()'
-
-    def dst(self, dt):
-        return self.ZERO
-
-    def tzname(self, dt):
-        return 'UTC'
-
-    def utcoffset(self, dt):
-        return self.ZERO
-
-
 def stream_response_to_file(response, path=None):
     """Stream a response body to the specified file.
 
diff --git a/setup.py b/setup.py
@@ -34,7 +34,11 @@
     os.system("python setup.py bdist_wheel sdist upload")
     sys.exit()
 
-requires.extend(["requests >= 2.18", "uritemplate >= 3.0.0"])
+requires.extend([
+    "requests >= 2.18",
+    "uritemplate >= 3.0.0",
+    "python-dateutil >= 2.6.0",
+])
 
 __version__ = ''
 with open('github3/__about__.py', 'r') as fd:
