Fix Producer delivery report error object leaks

edenhill · edenhill · commit 5a548b1dca93 · 2019-01-22T13:44:43.000+01:00
diff --git a/confluent_kafka/src/Producer.c b/confluent_kafka/src/Producer.c
@@ -146,9 +146,7 @@ static void dr_msg_cb (rd_kafka_t *rk, const rd_kafka_message_t *rkm,
 
 	msgobj = Message_new0(self, rkm);
 	
-	args = Py_BuildValue("(OO)",
-			     Message_error((Message *)msgobj, NULL),
-			     msgobj);
+        args = Py_BuildValue("(OO)", ((Message *)msgobj)->error, msgobj);
 
 	Py_DECREF(msgobj);
 
diff --git a/confluent_kafka/src/confluent_kafka.c b/confluent_kafka/src/confluent_kafka.c
@@ -343,6 +343,10 @@ static void cfl_PyErr_Fatal (rd_kafka_resp_err_t err, const char *reason) {
  ****************************************************************************/
 
 
+/**
+ * @returns a Message's error object, if any, else None.
+ * @remark The error object refcount is increased by this function.
+ */
 PyObject *Message_error (Message *self, PyObject *ignore) {
 	if (self->error) {
 		Py_INCREF(self->error);
