From 6e5e462bcd981e057e2a2b8d311f7d96b6ef37e1 Mon Sep 17 00:00:00 2001
From: Archmonger <16909269+Archmonger@users.noreply.github.com>
Date: Fri, 10 Jan 2025 19:03:22 -0800
Subject: [PATCH 1/2] Add missing changelog header
---
CHANGELOG.md | 2 ++
1 file changed, 2 insertions(+)
diff --git a/CHANGELOG.md b/CHANGELOG.md
index cfe26b7f..c6fa5cc3 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -23,6 +23,8 @@ Don't forget to remove deprecated code on each major release!
### [5.2.1] - 2025-01-10
+### Changed
+
- Use the latest version of `@reactpy/client` which includes a fix for needless client-side component re-creation.
### [5.2.0] - 2024-12-29
From 85a9e3fb7c34617d9c8f609d787d386d144063f5 Mon Sep 17 00:00:00 2001
From: Archmonger <16909269+Archmonger@users.noreply.github.com>
Date: Fri, 10 Jan 2025 19:29:24 -0800
Subject: [PATCH 2/2] Attempt to fix tests
---
tests/test_app/tests/js/button-from-js-module.js | 6 ------
tests/test_app/tests/test_components.py | 2 +-
2 files changed, 1 insertion(+), 7 deletions(-)
diff --git a/tests/test_app/tests/js/button-from-js-module.js b/tests/test_app/tests/js/button-from-js-module.js
index 2b49f505..55691d63 100644
--- a/tests/test_app/tests/js/button-from-js-module.js
+++ b/tests/test_app/tests/js/button-from-js-module.js
@@ -1,7 +1,4 @@
import { h, render } from "https://unpkg.com/preact?module";
-import htm from "https://unpkg.com/htm?module";
-
-const html = htm.bind(h);
export function bind(node, config) {
return {
@@ -16,9 +13,6 @@ export function SimpleButton(props) {
"button",
{
id: props.id,
- onClick(event) {
- props.onClick({ data: props.eventResponseData });
- },
},
"simple button",
);
diff --git a/tests/test_app/tests/test_components.py b/tests/test_app/tests/test_components.py
index 0a1e0c94..b5c47446 100644
--- a/tests/test_app/tests/test_components.py
+++ b/tests/test_app/tests/test_components.py
@@ -218,7 +218,7 @@ def test_component_session_exists(self):
@navigate_to_page("/")
def test_component_session_missing(self):
"""No session should exist for components that don't have args/kwargs."""
- component = self.page.locator("#button-from-js-module")
+ component = self.page.locator("#use-scope")
component.wait_for()
parent = component.locator("..")
session_id = parent.get_attribute("id")
pFad - Phonifier reborn
Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.
Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.
Alternative Proxies:
Alternative Proxy
pFad Proxy
pFad v3 Proxy
pFad v4 Proxy