Merge pull request #30 from clue-labs/the-future-is-now

WyriHaximus · web-flow · commit 1986075aa6e0 · 2022-02-18T09:12:23.000+01:00
Improve `async()` to avoid unneeded `futureTick()` calls
diff --git a/src/functions.php b/src/functions.php
@@ -164,7 +164,7 @@ function async(callable $function): callable
             }
         });
 
-        Loop::futureTick(static fn() => $fiber->start());
+        $fiber->start();
     });
 }
 
diff --git a/tests/AsyncTest.php b/tests/AsyncTest.php
@@ -8,25 +8,35 @@
 use function React\Async\async;
 use function React\Async\await;
 use function React\Promise\all;
+use function React\Promise\reject;
+use function React\Promise\resolve;
 
 class AsyncTest extends TestCase
 {
-    public function testAsyncReturnsPendingPromise()
+    public function testAsyncReturnsPromiseThatFulfillsWithValueWhenCallbackReturnsValue()
     {
         $promise = async(function () {
             return 42;
         })();
 
-        $promise->then($this->expectCallableNever(), $this->expectCallableNever());
+        $value = null;
+        $promise->then(function ($v) use (&$value) {
+            $value = $v;
+        });
+
+        $this->assertEquals(42, $value);
     }
 
-    public function testAsyncReturnsPromiseThatFulfillsWithValueWhenCallbackReturns()
+    public function testAsyncReturnsPromiseThatFulfillsWithValueWhenCallbackReturnsPromiseThatFulfillsWithValue()
     {
         $promise = async(function () {
-            return 42;
+            return resolve(42);
         })();
 
-        $value = await($promise);
+        $value = null;
+        $promise->then(function ($v) use (&$value) {
+            $value = $v;
+        });
 
         $this->assertEquals(42, $value);
     }
@@ -37,10 +47,41 @@ public function testAsyncReturnsPromiseThatRejectsWithExceptionWhenCallbackThrow
             throw new \RuntimeException('Foo', 42);
         })();
 
-        $this->expectException(\RuntimeException::class);
-        $this->expectExceptionMessage('Foo');
-        $this->expectExceptionCode(42);
-        await($promise);
+        $exception = null;
+        $promise->then(null, function ($reason) use (&$exception) {
+            $exception = $reason;
+        });
+
+        assert($exception instanceof \RuntimeException);
+        $this->assertInstanceOf(\RuntimeException::class, $exception);
+        $this->assertEquals('Foo', $exception->getMessage());
+        $this->assertEquals(42, $exception->getCode());
+    }
+
+    public function testAsyncReturnsPromiseThatRejectsWithExceptionWhenCallbackReturnsPromiseThatRejectsWithException()
+    {
+        $promise = async(function () {
+            return reject(new \RuntimeException('Foo', 42));
+        })();
+
+        $exception = null;
+        $promise->then(null, function ($reason) use (&$exception) {
+            $exception = $reason;
+        });
+
+        assert($exception instanceof \RuntimeException);
+        $this->assertInstanceOf(\RuntimeException::class, $exception);
+        $this->assertEquals('Foo', $exception->getMessage());
+        $this->assertEquals(42, $exception->getCode());
+    }
+
+    public function testAsyncReturnsPendingPromiseWhenCallbackReturnsPendingPromise()
+    {
+        $promise = async(function () {
+            return new Promise(function () { });
+        })();
+
+        $promise->then($this->expectCallableNever(), $this->expectCallableNever());
     }
 
     public function testAsyncReturnsPromiseThatFulfillsWithValueWhenCallbackReturnsAfterAwaitingPromise()

Original file line number	Diff line number	Diff line change
`@@ -164,7 +164,7 @@ function async(callable $function): callable`
`164`	`164`	`}`
`165`	`165`	`});`
`166`	`166`
`167`		`- Loop::futureTick(static fn() => $fiber->start());`
	`167`	`+ $fiber->start();`
`168`	`168`	`});`
`169`	`169`	`}`
`170`	`170`