Use libev->breakLoop() instead of suspend/resume

igorw · igorw · commit 2aa13a943f38 · 2012-12-16T23:03:19.000+01:00
Suspend does not break the loop, so the run call would still block.
BreakLoop however breaks out, and a future run() will continue the loop.
diff --git a/LibEvLoop.php b/LibEvLoop.php
@@ -12,7 +12,6 @@ class LibEvLoop implements LoopInterface
     private $readEvents = array();
     private $writeEvents = array();
     private $timers = array();
-    private $suspended = false;
 
     public function __construct()
     {
@@ -138,17 +137,11 @@ public function tick()
 
     public function run()
     {
-        if ($this->suspended) {
-            $this->suspended = false;
-            $this->loop->resume();
-        } else {
-            $this->loop->run();
-        }
+        $this->loop->run();
     }
 
     public function stop()
     {
-        $this->loop->suspend();
-        $this->suspended = true;
+        $this->loop->breakLoop();
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,6 @@ class LibEvLoop implements LoopInterface`
`12`	`12`	`private $readEvents = array();`
`13`	`13`	`private $writeEvents = array();`
`14`	`14`	`private $timers = array();`
`15`		`- private $suspended = false;`
`16`	`15`
`17`	`16`	`public function __construct()`
`18`	`17`	`{`
`@@ -138,17 +137,11 @@ public function tick()`
`138`	`137`
`139`	`138`	`public function run()`
`140`	`139`	`{`
`141`		`- if ($this->suspended) {`
`142`		`- $this->suspended = false;`
`143`		`- $this->loop->resume();`
`144`		`- } else {`
`145`		`- $this->loop->run();`
`146`		`- }`
	`140`	`+ $this->loop->run();`
`147`	`141`	`}`
`148`	`142`
`149`	`143`	`public function stop()`
`150`	`144`	`{`
`151`		`- $this->loop->suspend();`
`152`		`- $this->suspended = true;`
	`145`	`+ $this->loop->breakLoop();`
`153`	`146`	`}`
`154`	`147`	`}`