Favour isset() over array_key_exists().

jmalloc · jmalloc · commit 35e386c0bd8b · 2013-11-14T07:36:49.000+10:00
diff --git a/ExtEventLoop.php b/ExtEventLoop.php
@@ -92,7 +92,7 @@ public function removeStream($stream)
     {
         $key = (int) $stream;
 
-        if (!array_key_exists($key, $this->streamEvents)) {
+        if (!isset($this->streamEvents[$key])) {
             return;
         }
 
@@ -250,7 +250,7 @@ protected function addStreamEvent($stream, $flag, $listener)
     {
         $key = (int) $stream;
 
-        if (array_key_exists($key, $this->streamEvents)) {
+        if (isset($this->streamEvents[$key])) {
             $entry = $this->streamEvents[$key];
         } else {
             $entry = new stdClass;
@@ -298,7 +298,7 @@ protected function removeStreamEvent($stream, $flag)
     {
         $key = (int) $stream;
 
-        if (!array_key_exists($key, $this->streamEvents)) {
+        if (!isset($this->streamEvents[$key])) {
             return;
         }
 
diff --git a/StreamSelectNextTickLoop.php b/StreamSelectNextTickLoop.php
@@ -34,7 +34,7 @@ public function addReadStream($stream, $listener)
     {
         $key = (int) $stream;
 
-        if (!array_key_exists($key, $this->readStreams)) {
+        if (!isset($this->readStreams[$key])) {
             $this->readStreams[$key] = $stream;
             $this->readListeners[$key] = $listener;
         }
@@ -50,7 +50,7 @@ public function addWriteStream($stream, $listener)
     {
         $key = (int) $stream;
 
-        if (!array_key_exists($key, $this->writeStreams)) {
+        if (!isset($this->writeStreams[$key])) {
             $this->writeStreams[$key] = $stream;
             $this->writeListeners[$key] = $listener;
         }
@@ -209,7 +209,7 @@ protected function waitForStreamActivity($blocking)
         foreach ($read as $stream) {
             $key = (int) $stream;
 
-            if (array_key_exists($key, $this->readListeners)) {
+            if (isset($this->readListeners[$key])) {
                 call_user_func($this->readListeners[$key], $stream, $this);
             }
         }
@@ -218,7 +218,7 @@ protected function waitForStreamActivity($blocking)
         foreach ($write as $stream) {
             $key = (int) $stream;
 
-            if (array_key_exists($key, $this->writeListeners)) {
+            if (isset($this->writeListeners[$key])) {
                 call_user_func($this->writeListeners[$key], $stream, $this);
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,7 @@ public function removeStream($stream)`
`92`	`92`	`{`
`93`	`93`	`$key = (int) $stream;`
`94`	`94`
`95`		`- if (!array_key_exists($key, $this->streamEvents)) {`
	`95`	`+ if (!isset($this->streamEvents[$key])) {`
`96`	`96`	`return;`
`97`	`97`	`}`
`98`	`98`
`@@ -250,7 +250,7 @@ protected function addStreamEvent($stream, $flag, $listener)`
`250`	`250`	`{`
`251`	`251`	`$key = (int) $stream;`
`252`	`252`
`253`		`- if (array_key_exists($key, $this->streamEvents)) {`
	`253`	`+ if (isset($this->streamEvents[$key])) {`
`254`	`254`	`$entry = $this->streamEvents[$key];`
`255`	`255`	`} else {`
`256`	`256`	`$entry = new stdClass;`
`@@ -298,7 +298,7 @@ protected function removeStreamEvent($stream, $flag)`
`298`	`298`	`{`
`299`	`299`	`$key = (int) $stream;`
`300`	`300`
`301`		`- if (!array_key_exists($key, $this->streamEvents)) {`
	`301`	`+ if (!isset($this->streamEvents[$key])) {`
`302`	`302`	`return;`
`303`	`303`	`}`
`304`	`304`
Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ public function addReadStream($stream, $listener)`
`34`	`34`	`{`
`35`	`35`	`$key = (int) $stream;`
`36`	`36`
`37`		`- if (!array_key_exists($key, $this->readStreams)) {`
	`37`	`+ if (!isset($this->readStreams[$key])) {`
`38`	`38`	`$this->readStreams[$key] = $stream;`
`39`	`39`	`$this->readListeners[$key] = $listener;`
`40`	`40`	`}`
`@@ -50,7 +50,7 @@ public function addWriteStream($stream, $listener)`
`50`	`50`	`{`
`51`	`51`	`$key = (int) $stream;`
`52`	`52`
`53`		`- if (!array_key_exists($key, $this->writeStreams)) {`
	`53`	`+ if (!isset($this->writeStreams[$key])) {`
`54`	`54`	`$this->writeStreams[$key] = $stream;`
`55`	`55`	`$this->writeListeners[$key] = $listener;`
`56`	`56`	`}`
`@@ -209,7 +209,7 @@ protected function waitForStreamActivity($blocking)`
`209`	`209`	`foreach ($read as $stream) {`
`210`	`210`	`$key = (int) $stream;`
`211`	`211`
`212`		`- if (array_key_exists($key, $this->readListeners)) {`
	`212`	`+ if (isset($this->readListeners[$key])) {`
`213`	`213`	`call_user_func($this->readListeners[$key], $stream, $this);`
`214`	`214`	`}`
`215`	`215`	`}`
`@@ -218,7 +218,7 @@ protected function waitForStreamActivity($blocking)`
`218`	`218`	`foreach ($write as $stream) {`
`219`	`219`	`$key = (int) $stream;`
`220`	`220`
`221`		`- if (array_key_exists($key, $this->writeListeners)) {`
	`221`	`+ if (isset($this->writeListeners[$key])) {`
`222`	`222`	`call_user_func($this->writeListeners[$key], $stream, $this);`
`223`	`223`	`}`
`224`	`224`	`}`