[EventLoop] Stop loop before throwing exception (removing stream is not enough)

igorw · igorw · commit 8eeb5c019d98 · 2012-06-14T22:48:30.000+02:00
diff --git a/LibEventLoop.php b/LibEventLoop.php
@@ -52,9 +52,9 @@ protected function createLibeventCallback()
                     }
                 }
             } catch (\Exception $ex) {
-                // If one of the callbacks throws an exception we must remove the stream
+                // If one of the callbacks throws an exception we must stop the loop
                 // otherwise libevent will swallow the exception and go berserk.
-                $loop->removeStream($stream);
+                $loop->stop();
 
                 throw $ex;
             }

Original file line number	Diff line number	Diff line change
`@@ -52,9 +52,9 @@ protected function createLibeventCallback()`
`52`	`52`	`}`
`53`	`53`	`}`
`54`	`54`	`} catch (\Exception $ex) {`
`55`		`- // If one of the callbacks throws an exception we must remove the stream`
	`55`	`+ // If one of the callbacks throws an exception we must stop the loop`
`56`	`56`	`// otherwise libevent will swallow the exception and go berserk.`
`57`		`- $loop->removeStream($stream);`
	`57`	`+ $loop->stop();`
`58`	`58`
`59`	`59`	`throw $ex;`
`60`	`60`	`}`