-
-
Notifications
You must be signed in to change notification settings - Fork 132
Closed
Labels
Milestone
Description
Before attempting a refactor proposition at the StreamSelectLoop class I was running unit tests, and found out that they run forever.
My first guess is that testTimerIntervalCanBeFarInFuture
got a deadlock with the socket pair. As the test says about creating a tick far in the future I see no reason to use I/O for it anyways.
This PR here removes the I/O dependency and relies only at the futureTick
implementation.
I'm running a MacOS system and php 7.1