Skip to content

[RFC] Remove all callable type hints for consistency and performance reasons #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 22, 2017
Merged

[RFC] Remove all callable type hints for consistency and performance reasons #141

merged 1 commit into from
Dec 22, 2017

Conversation

clue
Copy link
Member

@clue clue commented Dec 20, 2017

I'm filing this PR as an RFC to see if it makes sense to drop these type hints.

@clue
Copy link
Member Author

clue commented Dec 20, 2017

I've seen a 5% to 10% performance improvement running any of the benchmarks from the examples/folder and have also seen some similar performance improvements in running some higher level applications (I/O intensive) with this applied.

Note that I'm not suggesting we remove all type hints. This PR merely aims to remove the callable type hint only – also for consistency reasons with the whole API. Also note that this does not contradict our efforts to eventually update to PHP 7 only (reactphp/reactphp#374), in which case we will likely reconsider adding consistent type hints for all relevant APIs.

@WyriHaximus WyriHaximus added this to the v0.5.0 milestone Dec 20, 2017
WyriHaximus
WyriHaximus approved these changes Dec 22, 2017
View reviewed changes
Copy link
Member

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a nice and welcome performance improvement, LGTM :shipit:

jsor
jsor approved these changes Dec 22, 2017
View reviewed changes
Copy link
Member

@jsor jsor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mixed $feelings, but :shipit: 😉

@jsor jsor merged commit e18ee06 into reactphp:master Dec 22, 2017
@clue clue deleted the callable branch December 22, 2017 14:57
morrisonlevi
morrisonlevi reviewed Dec 22, 2017
View reviewed changes
Copy link

@morrisonlevi morrisonlevi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... what? I'm not a react-php user so definitely feel free to ignore me but... what does "consistency" even mean here? I would also hope any loss of type-safety for performance reasons would also be backed by reproducible numbers; is there some missing context from this PR?

Edit: A bit of background: I've altered the engine to no-op the type-checking in the past. This did not register a significant improvement gain; this is why I do not trust the claim. Again, I'm not using this project so take my complaint with that in mind.

@kelunik
Copy link
Contributor

kelunik commented Dec 22, 2017

I can't reproduce any improvements in examples/94-benchmark-timers-delay.php either. Which benchmark specifically did you run and which numbers did you get?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morrisonlevi morrisonlevi morrisonlevi left review comments

@jsor jsor jsor approved these changes

@WyriHaximus WyriHaximus WyriHaximus approved these changes

Assignees
No one assigned
Labels
BC break easy pick
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.
5 participants
@clue @kelunik @jsor @WyriHaximus @morrisonlevi
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy