Skip to content

[RFC] Improve compatibility with legacy versions #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2018

Conversation

clue
Copy link
Member

@clue clue commented Feb 6, 2018

Because why not… :-)

Now more seriously: This project is a low level lib that is used as a building block for quite a few higher level abstractions on top of it. As such, compatibility (even with significantly outdated versions) is a major concern to me.

Note that I'm not suggesting putting significant amount of work into this. The patch is already here and, personally, I see little harm in supporting this.

Also note that I'm not suggesting we need to keep support indefinitely. Should this ever turn out to be a burden in the future, e.g. because we actually require any new language features or some external lib, then I'm all for dropping support again. If you want to discuss this further, I would suggest directing this to reactphp/reactphp#374 instead 👍

@clue clue added this to the v0.5.0 milestone Feb 6, 2018
@clue clue force-pushed the trolol branch 4 times, most recently from 0c386b0 to 0079dcb Compare February 6, 2018 20:54
Copy link
Member

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jsor jsor merged commit a35b37f into reactphp:master Feb 7, 2018
@clue clue deleted the trolol branch February 7, 2018 08:11
@nick4fake
Copy link

Improving compatibility with old versions is totally ok if that does not limit your future changes. Are you sure PHP5.3/5.4/5.5 are really important to support?

@clue
Copy link
Member Author

clue commented Apr 11, 2018

@nick4fake I think we all agree that this is a highly political topic and I believe most of this has been discussed in reactphp/reactphp#374 (comment) (another others) already.

The gist here is that using outdated versions is most likely a bad idea – however, older versions do no currently block or limit us on what is planned for the stable v1.0.0 release. As such, there are no immediate plans to drop support for any older versions, which allows consumers of our packages to safely update without having to worry about this for now.

In case anybody is still wondering: We highly recommend running a supported version of PHP (which again is explicitly documented in each components' install instructions).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy