ExtEventLoop: Remove optional EventBaseConfig and make FEATURE_FDS enabled by default #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clue
reviewed
Mar 12, 2018
There was a problem hiding this comment.
This looks like a sane default behavior to me as it also fixes issues with STDIO-streams exposing the underlying FD is a file is piped etc..
I would vote to apply this as default behavior and remove the config parameter altogether as per #154 until we find a valid use case where an explicit config makes more sense?
|
Makes sense, I'll update the PR 👍 |
|
Done |
jsor
approved these changes
Mar 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mutually exclusive with #154
This came up in a discussion after #154 was filed and because doing this by default will be provide a better BC.