Skip to content

Allow throwing Exception if stream resource is not supported #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2018
Merged

Allow throwing Exception if stream resource is not supported #158

merged 1 commit into from
Mar 26, 2018

Conversation

clue
Copy link
Member

@clue clue commented Mar 26, 2018 •
edited
Loading

This very simple PR adds documentation to make consumers aware that addReadStream() and addWriteStream() MAY throw an Exception if the given stream resource type is not supported by the underlying event loop implementation. This is explicitly not enforced due to performance considerations, so consumers SHOULD NOT rely on this.

Builds on top of #110

@clue clue added this to the v0.5.0 milestone Mar 26, 2018
@WyriHaximus WyriHaximus requested review from jsor and WyriHaximus March 26, 2018 14:10
@WyriHaximus WyriHaximus merged commit 1fb6a4b into reactphp:master Mar 26, 2018
@clue clue deleted the exception branch March 26, 2018 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsor jsor jsor approved these changes

@WyriHaximus WyriHaximus WyriHaximus approved these changes

Assignees
No one assigned
Labels
easy pick maintenance
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@clue @jsor @WyriHaximus
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy