From 5504145ee88dbaee81e3b73502ba4c287687821b Mon Sep 17 00:00:00 2001 From: Nikita Makarov Date: Mon, 29 Apr 2019 11:14:12 +0300 Subject: [PATCH 1/4] ISSUE-189: EventBaseConfig::FEATURE_FDS not supported on Windows - Added exclusion for Windows platform --- .gitignore | 1 + src/ExtEventLoop.php | 6 +++++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/.gitignore b/.gitignore index 81b92580..79281abb 100644 --- a/.gitignore +++ b/.gitignore @@ -1,3 +1,4 @@ composer.lock phpunit.xml vendor +.idea diff --git a/src/ExtEventLoop.php b/src/ExtEventLoop.php index fd403d4a..4ebec31f 100644 --- a/src/ExtEventLoop.php +++ b/src/ExtEventLoop.php @@ -44,7 +44,11 @@ public function __construct() } $config = new EventBaseConfig(); - $config->requireFeatures(EventBaseConfig::FEATURE_FDS); + if ('WIN' === strtoupper(substr(PHP_OS, 0, 3))) { + // Skip `EventBaseConfig::FEATURE_FDS` due an issue https://github.com/reactphp/event-loop/issues/189 + }else { + $config->requireFeatures(EventBaseConfig::FEATURE_FDS); + } $this->eventBase = new EventBase($config); $this->futureTickQueue = new FutureTickQueue(); From a5899515dba29abd4bdcc545af9fad6cf3203375 Mon Sep 17 00:00:00 2001 From: Nikita Makarov Date: Fri, 12 Jul 2019 16:07:44 +0300 Subject: [PATCH 2/4] CR fixes --- README.md | 5 +++++ src/ExtEventLoop.php | 5 ++--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 029042e0..c6ff70db 100644 --- a/README.md +++ b/README.md @@ -38,6 +38,7 @@ single [`run()`](#run) call that is controlled by the user. * [Install](#install) * [Tests](#tests) * [License](#license) +* [Known issues](#known-issues) * [More](#more) ## Quickstart example @@ -704,6 +705,10 @@ $ php vendor/bin/phpunit MIT, see [LICENSE file](LICENSE). +## Known Issues +* _*pecl-event*_ on Windows is not capable of accepting arbitrary file descriptor types (`EventBaseConfig::FEATURE_FDS`). + Instead if an user requires this feature, _*libuv*_ should be used. [Related issue](https://github.com/reactphp/event-loop/issues/189) + ## More * See our [Stream component](https://github.com/reactphp/stream) for more diff --git a/src/ExtEventLoop.php b/src/ExtEventLoop.php index 4ebec31f..5296f0e5 100644 --- a/src/ExtEventLoop.php +++ b/src/ExtEventLoop.php @@ -44,9 +44,8 @@ public function __construct() } $config = new EventBaseConfig(); - if ('WIN' === strtoupper(substr(PHP_OS, 0, 3))) { - // Skip `EventBaseConfig::FEATURE_FDS` due an issue https://github.com/reactphp/event-loop/issues/189 - }else { + // Skip `EventBaseConfig::FEATURE_FDS` due an issue https://github.com/reactphp/event-loop/issues/189 + if ('WIN' !== strtoupper(substr(PHP_OS, 0, 3))) { $config->requireFeatures(EventBaseConfig::FEATURE_FDS); } From 3e0b01b4e2521fbe7993582d85d8b3088c093db7 Mon Sep 17 00:00:00 2001 From: Nikita Makarov Date: Fri, 12 Jul 2019 16:22:05 +0300 Subject: [PATCH 3/4] CR: Changed alias `EventBaseConfig` to class `EventConfig` in the docs --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index c6ff70db..9fe50686 100644 --- a/README.md +++ b/README.md @@ -706,7 +706,7 @@ $ php vendor/bin/phpunit MIT, see [LICENSE file](LICENSE). ## Known Issues -* _*pecl-event*_ on Windows is not capable of accepting arbitrary file descriptor types (`EventBaseConfig::FEATURE_FDS`). +* _*pecl-event*_ on Windows is not capable of accepting arbitrary file descriptor types (`EventConfig::FEATURE_FDS`). Instead if an user requires this feature, _*libuv*_ should be used. [Related issue](https://github.com/reactphp/event-loop/issues/189) ## More From d5967e47b1535dbb9458e8266ccb47d54890b45b Mon Sep 17 00:00:00 2001 From: Nikita Makarov Date: Tue, 16 Jul 2019 10:42:31 +0300 Subject: [PATCH 4/4] Removed ".idea" from ".gitignore" --- .gitignore | 1 - 1 file changed, 1 deletion(-) diff --git a/.gitignore b/.gitignore index 79281abb..81b92580 100644 --- a/.gitignore +++ b/.gitignore @@ -1,4 +1,3 @@ composer.lock phpunit.xml vendor -.idea pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy