Avoid deprecation warnings in test suite due to deprecation of getMock() in PHPUnit #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We've currently decided to add PHPUnit 4.8 to require-dev of each component, see reactphp/reactphp#354. This will fix this issue. As a side note: i've also fixed this latetly in react/promise by using $this
->getMockBuilder('React\Promise\Stub\CallableStub')
->getMock();This works in all version of PHPUnit, see reactphp/promise@73f2304#diff-d4c8c6dc8769324fc27cfdac19f05caf |
|
Should i change the PR to use mock builder or close it and let you introduce PHPUnit 4.8 instead? |
|
I'd vote for getting this in for forward compatibility and to avoid warnings when users run the tests not from vendors but with their local version of PHPUnit. |
jsor
approved these changes
Jan 11, 2017
WyriHaximus
approved these changes
Jan 11, 2017
clue
approved these changes
Jan 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method
getMock()was deprecated with the release of PHPUnit 5.4. The same release introducedcreateMock()that should be used to create mock objects instead. This PR modifiesReact\Tests\EventLoop\TestCase::createCallableMock()to use the new mock API if available.