Skip to content

Run tests on windows using AppVeyor #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 13, 2017

Conversation

WyriHaximus
Copy link
Member

#71 made me realize that we don't test on windows, this PR adds the configuration to do that.

@WyriHaximus WyriHaximus requested review from nrk, jsor and clue February 12, 2017 16:25
@WyriHaximus
Copy link
Member Author

So we can do two things, I either start figuring out how to install as much event loop extensions as possible or create new PR's for each event loop extension so this can be merged in (after review).

Copy link
Member

@jsor jsor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have zero experience with AppVeyor, so feel free to do what you think is the best :)

@WyriHaximus
Copy link
Member Author

In my personal opinion is doing separate PR's per loop extension the best way forward. I have zero experience with extensions on windows

@clue clue added this to the v0.5.0 milestone Feb 13, 2017
@clue clue merged commit 8bb87db into reactphp:master Feb 13, 2017
@nrk
Copy link
Member

nrk commented Feb 13, 2017

Right now only the event PECL extension has prebuilt DLLs for Windows available on PECL making it probably the easier target to start with it (well aside from React\EventLoop\StreamSelectLoop).

The ev extension we are currently using is not on PECL and doesn't have a config.w32 so it's highly unlikely to work on the Windows platform or at least it's definitely untested. Considering the state of this extension I'm not sure it's even worth to try.

On the other hand the ev PECL extension, for which we have pending PRs for an event loop implementation and is more future-proof from our POV, doesn't have prebuilt binaries on PECL but does have a config.w32 so it's probably worth a try, at least starting with something local. I don't know AppVeyor much so I don't know how much flexibility it allows in regards to building stuff, but I've just noticed that they have images with Visual Studio as a development environment so it should be somehow possibile. Having prebuilt binaries would be actually better for us, obviously.

The last time I tinkered with PHP on Windows was probably like 2006 or something 🤢 💩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy