Merge pull request #186 from reactphp/sink-factory-readable

cboden · cboden · commit 1809f27bc917 · 2013-04-21T06:29:46.000-07:00
Allow any `ReadableStreamInterface` on `BufferedSink::createPromise()
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,7 @@ CHANGELOG
 
 ### 0.3.1 (2013-04-21)
 
+  * Bug fix: [Stream] Allow any `ReadableStreamInterface` on `BufferedSink::createPromise()`
   * Bug fix: [HttpClient] Correct requirement for socket-client
 
 ### 0.3.0 (2013-04-14)
diff --git a/src/React/Stream/BufferedSink.php b/src/React/Stream/BufferedSink.php
@@ -4,7 +4,6 @@
 
 use React\Promise\Deferred;
 use React\Promise\PromisorInterface;
-use React\Stream\WritableStream;
 
 class BufferedSink extends WritableStream implements PromisorInterface
 {
@@ -50,7 +49,7 @@ public function promise()
         return $this->deferred->promise();
     }
 
-    public static function createPromise(ReadableStream $stream)
+    public static function createPromise(ReadableStreamInterface $stream)
     {
         $sink = new static();
         $stream->pipe($sink);

Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,6 @@`
`4`	`4`
`5`	`5`	`use React\Promise\Deferred;`
`6`	`6`	`use React\Promise\PromisorInterface;`
`7`		`-use React\Stream\WritableStream;`
`8`	`7`
`9`	`8`	`class BufferedSink extends WritableStream implements PromisorInterface`
`10`	`9`	`{`
`@@ -50,7 +49,7 @@ public function promise()`
`50`	`49`	`return $this->deferred->promise();`
`51`	`50`	`}`
`52`	`51`
`53`		`- public static function createPromise(ReadableStream $stream)`
	`52`	`+ public static function createPromise(ReadableStreamInterface $stream)`
`54`	`53`	`{`
`55`	`54`	`$sink = new static();`
`56`	`55`	`$stream->pipe($sink);`