unit tests for py socket

Arthur Guigand · cboden · commit 63925d12bfb3 · 2014-04-13T10:55:19.000-04:00
diff --git a/src/Socket/Connection.php b/src/Socket/Connection.php
@@ -11,7 +11,7 @@ public function handleData($stream)
         // Socket is raw, not using fread as it's interceptable by filters
         // See issues #192, #209, and #240
         $data = stream_socket_recvfrom($stream, $this->bufferSize);
-        if( '' != $data || false != $data ){
+        if( '' !== $data || false !== $data ){
             $this->emit('data', array($data, $this));
         }
         if ('' === $data || false === $data || feof($stream)) {
diff --git a/tests/Socket/ServerTest.php b/tests/Socket/ServerTest.php
@@ -84,15 +84,40 @@ public function testDataWithNoData()
     public function testData()
     {
         $client = stream_socket_client('tcp://localhost:'.$this->port);
-
+        
         fwrite($client, "foo\n");
+        
+        $mock = $this->createCallableMock();
+        $mock
+            ->expects($this->once())
+            ->method('__invoke')
+            ->with("foo\n");
 
+        $this->server->on('connection', function ($conn) use ($mock) {
+            $conn->on('data', $mock);
+        });
+        $this->loop->tick();
+        $this->loop->tick();
+    }
+    
+    /**
+     * Test data sent from python language
+     * 
+     * @covers React\EventLoop\StreamSelectLoop::tick
+     * @covers React\Socket\Connection::handleData
+     */
+    public function testDataSentFromPy()
+    {
+        $cmd = "python -c 'import socket; s = socket.socket(socket.AF_INET, socket.SOCK_STREAM);s.connect((\"127.0.0.1\", $this->port));s.sendall(\"foo\\n\");s.shutdown(1);'";
+        exec($cmd);
+        
         $mock = $this->createCallableMock();
         $mock
             ->expects($this->once())
             ->method('__invoke')
             ->with("foo\n");
 
+                  
         $this->server->on('connection', function ($conn) use ($mock) {
             $conn->on('data', $mock);
         });

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ public function handleData($stream)`
`11`	`11`	`// Socket is raw, not using fread as it's interceptable by filters`
`12`	`12`	`// See issues #192, #209, and #240`
`13`	`13`	`$data = stream_socket_recvfrom($stream, $this->bufferSize);`
`14`		`- if( '' != $data \|\| false != $data ){`
	`14`	`+ if( '' !== $data \|\| false !== $data ){`
`15`	`15`	`$this->emit('data', array($data, $this));`
`16`	`16`	`}`
`17`	`17`	`if ('' === $data \|\| false === $data \|\| feof($stream)) {`