[EventLoop] Changed StreamSelectLoop to use non-blocking behavior on tic... #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Poke @nrk. |
|
Changes look good but I only did a code review without actually trying them (will do that later or tomorrow at worst). |
|
I will see if I can get some time here in the next day or so to add a test for this particular scenario. |
|
Ran several tests, no issues. Super Poke @nrk |
|
Here I am! |
|
Thanks @astephens25 + @nrk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the StreamSelectLoop does not exhibit the same non-blocking behavior as the LibEventLoop when using the
tick()method. I modified it to never block onstream_select()nor sleep on pending timers when using thetick()method and provided a new protected method for the internalrun()loop.The existing test for the StreamSelectLoop is quite bare, so I did not modify it. If you would prefer, I will gladly add a test for this modification.