Improve test suite to exclude TLS 1.3 tests on PHP 7.3

clue · clue · commit 198690e6b736 · 2019-11-17T20:44:51.000+01:00
Explicit TLS 1.3 support will be available in PHP 7.4: php/php-src#3909 Older PHP versions implicitly support TLS 1.3 provided that the underlying OpenSSL version supports TLS 1.3. However, for PHP 7.3 some recent changes implicitly disable TLS 1.3, so we skip TLS 1.3 tests on affected PHP versions: php/php-src#3317
diff --git a/tests/FunctionalSecureServerTest.php b/tests/FunctionalSecureServerTest.php
@@ -50,8 +50,11 @@ public function testClientCanConnectToServer()
 
     public function testClientUsesTls13ByDefaultWhenSupportedByOpenSSL()
     {
-        if (PHP_VERSION_ID < 70000 || !$this->supportsTls13()) {
-            $this->markTestSkipped('Test requires PHP 7+ for crypto meta data and OpenSSL 1.1.1+ for TLS 1.3');
+        if (PHP_VERSION_ID < 70000 || (PHP_VERSION_ID >= 70300 && PHP_VERSION_ID < 70400) || !$this->supportsTls13()) {
+            // @link https://github.com/php/php-src/pull/3909 explicitly adds TLS 1.3 on PHP 7.4
+            // @link https://github.com/php/php-src/pull/3317 implicitly limits to TLS 1.2 on PHP 7.3
+            // all older PHP versions support TLS 1.3 (provided OpenSSL supports it), but only PHP 7 allows checking the version
+            $this->markTestSkipped('Test requires PHP 7+ for crypto meta data (but excludes PHP 7.3 because it implicitly limits to TLS 1.2) and OpenSSL 1.1.1+ for TLS 1.3');
         }
 
         $loop = Factory::create();

Original file line number	Diff line number	Diff line change
`@@ -50,8 +50,11 @@ public function testClientCanConnectToServer()`
`50`	`50`
`51`	`51`	`public function testClientUsesTls13ByDefaultWhenSupportedByOpenSSL()`
`52`	`52`	`{`
`53`		`- if (PHP_VERSION_ID < 70000 \|\| !$this->supportsTls13()) {`
`54`		`- $this->markTestSkipped('Test requires PHP 7+ for crypto meta data and OpenSSL 1.1.1+ for TLS 1.3');`
	`53`	`+ if (PHP_VERSION_ID < 70000 \|\| (PHP_VERSION_ID >= 70300 && PHP_VERSION_ID < 70400) \|\| !$this->supportsTls13()) {`
	`54`	`+ // @link https://github.com/php/php-src/pull/3909 explicitly adds TLS 1.3 on PHP 7.4`
	`55`	`+ // @link https://github.com/php/php-src/pull/3317 implicitly limits to TLS 1.2 on PHP 7.3`
	`56`	`+ // all older PHP versions support TLS 1.3 (provided OpenSSL supports it), but only PHP 7 allows checking the version`
	`57`	`+ $this->markTestSkipped('Test requires PHP 7+ for crypto meta data (but excludes PHP 7.3 because it implicitly limits to TLS 1.2) and OpenSSL 1.1.1+ for TLS 1.3');`
`55`	`58`	`}`
`56`	`59`
`57`	`60`	`$loop = Factory::create();`