Merge pull request #292 from clue-labs/unneeded-nonblock

WyriHaximus · web-flow · commit dd3c325f3031 · 2022-05-20T22:42:07.000+02:00
Avoid unneeded syscall on socket close
diff --git a/src/Connection.php b/src/Connection.php
@@ -127,13 +127,9 @@ public function handleClose()
         }
 
         // Try to cleanly shut down socket and ignore any errors in case other
-        // side already closed. Shutting down may return to blocking mode on
-        // some legacy versions, so reset to non-blocking just in case before
-        // continuing to close the socket resource.
-        // Underlying Stream implementation will take care of closing file
-        // handle, so we otherwise keep this open here.
+        // side already closed. Underlying Stream implementation will take care
+        // of closing stream resource, so we otherwise keep this open here.
         @\stream_socket_shutdown($this->stream, \STREAM_SHUT_RDWR);
-        \stream_set_blocking($this->stream, false);
     }
 
     public function getRemoteAddress()

Original file line number	Diff line number	Diff line change
`@@ -127,13 +127,9 @@ public function handleClose()`
`127`	`127`	`}`
`128`	`128`
`129`	`129`	`// Try to cleanly shut down socket and ignore any errors in case other`
`130`		`- // side already closed. Shutting down may return to blocking mode on`
`131`		`- // some legacy versions, so reset to non-blocking just in case before`
`132`		`- // continuing to close the socket resource.`
`133`		`- // Underlying Stream implementation will take care of closing file`
`134`		`- // handle, so we otherwise keep this open here.`
	`130`	`+ // side already closed. Underlying Stream implementation will take care`
	`131`	`+ // of closing stream resource, so we otherwise keep this open here.`
`135`	`132`	`@\stream_socket_shutdown($this->stream, \STREAM_SHUT_RDWR);`
`136`		`- \stream_set_blocking($this->stream, false);`
`137`	`133`	`}`
`138`	`134`
`139`	`135`	`public function getRemoteAddress()`