Skip to content

Test against PHP 7.3 on travis #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2018

Conversation

WyriHaximus
Copy link
Member

No description provided.

@WyriHaximus WyriHaximus requested review from jsor and clue October 26, 2018 15:32
@clue clue added this to the v1.2.0 milestone Oct 27, 2018
@clue
Copy link
Member

clue commented Oct 27, 2018

The build output currently indicates that connecting to google.com with a timeout of 1 ms does not cause a timeout. Arguably, this test output could be a bit flaky depending on the timer resolution, the network speed and other factors. Is this something you're going to look into? 👍

@WyriHaximus
Copy link
Member Author

@clue currently looking into that, kicking that build a few times to ensure this was just a flaky run and not something more troubeling

@WyriHaximus
Copy link
Member Author

@clue @jsor Ok kick the build for a good half hour and it only failed about 5% of the time so IMHO it's ready to be reviewed

@jsor jsor merged commit 6cb21be into reactphp:master Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy