Improve test suite and switch to normal stream handler #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
WyriHaximus
approved these changes
Nov 29, 2016
jsor
approved these changes
Dec 19, 2016
This was referenced Feb 10, 2017
clue
added a commit
to clue-labs/socket
that referenced
this pull request
Mar 29, 2017
Add TimeoutConnector decorator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some additional test cases to verify we can use the normal stream handler which processes any stream filters and handles any errors.
It looks like the original motivation for using raw stream handlers was that some Autobahn tests failed "very oddly" (reactphp/reactphp#240). I assume this might have been fixed in the meantime, possibly as part of reactphp/stream#20.