Skip to content

Rename shutdown() to close() for consistency throughout React #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 27, 2017
Merged

Rename shutdown() to close() for consistency throughout React #62

merged 1 commit into from
Jan 27, 2017

Conversation

clue
Copy link
Member

@clue clue commented Jan 17, 2017 •
edited
Loading

This very simple PR renames the shutdown() method to close() in order to achieve consistency throughout React's components.

The term "shutdown" is actually an implementation detail of sockets and does not really apply to closing a server socket.

FWIW, Node also uses "close".

@clue clue added this to the v0.5.0 milestone Jan 17, 2017
jsor
jsor approved these changes Jan 17, 2017
View reviewed changes
Copy link
Member

@jsor jsor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although $server->shutdown() reads better than $server->close() IMHO, 👍 for consistency.

WyriHaximus
WyriHaximus approved these changes Jan 27, 2017
View reviewed changes
Copy link
Member

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@clue clue merged commit f1e457d into reactphp:master Jan 27, 2017
@clue clue deleted the close branch January 27, 2017 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsor jsor jsor approved these changes

@WyriHaximus WyriHaximus WyriHaximus approved these changes

Assignees
No one assigned
Labels
BC break maintenance
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@clue @jsor @WyriHaximus
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy