Skip to content

Add LimitingServer to limit and keep track of open connections #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 4, 2017
Merged

Add LimitingServer to limit and keep track of open connections #86

merged 3 commits into from
Apr 4, 2017

Conversation

clue
Copy link
Member

@clue clue commented Apr 2, 2017 •
edited
Loading

Add LimitingServer to limit number of open connections. This can be useful to limit how many resources are spent on handling connections vs. handling the requests that arrive on each connection (HTTP).

Builds on top of #84

@clue clue added this to the v0.6.0 milestone Apr 2, 2017
@clue
Copy link
Member Author

clue commented Apr 3, 2017

Updated to work around a legacy PHP 5.3 issue due to old react/event-loop :shipit:

@jsor
Copy link
Member

jsor commented Apr 3, 2017

Out of curiosity: Is Accounting a common term for this? Because when i've read the notification of this PR, i've been very confused by the name ;)

@jsor jsor requested review from jsor and removed request for jsor April 3, 2017 17:18
@clue
Copy link
Member Author

clue commented Apr 3, 2017

Afaict "accounting" is not a common name for this feature and I'm open for suggestions :-) Afaict, this is not exactly a common feature in the first place, because this is often implemented as part of the underlying "server" instead of via decoration. Given our current design, I would vote to keep this via decoration (e.g. this allows us to limit the number of TLS connections), but I'm not opposed to renaming this feature 👍

FWIW, the name "accounting" is related to "accountant" or "book keeping", which I think is good fit for this feature, because it does more than just "limiting".

@jsor
Copy link
Member

jsor commented Apr 3, 2017

FWIW, the name "accounting" is related to "accountant" or "book keeping", which I think is good fit for this feature, because it does more than just "limiting".

Yeah, i figured after seeing the code, but looked strange just from the name ;)

What about ConnectionControllingServer?

@WyriHaximus WyriHaximus requested review from jsor and WyriHaximus April 4, 2017 13:09
WyriHaximus
WyriHaximus approved these changes Apr 4, 2017
View reviewed changes
Copy link
Member

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please! :shipit: :shipit: :shipit:

P.S. When reading into what it does, the name, AccountingServer makes a lot of sense 👍

@clue clue changed the title Add AccountingServer to keep track of (limit of) open connections Add LimitingServer to limit and keep track of open connections Apr 4, 2017
@clue
Copy link
Member Author

clue commented Apr 4, 2017

Alright, renamed AccountingServer to LimitingServer, as I think confusion with "managing accounts" is a valid concern 👍 :shipit:

@WyriHaximus WyriHaximus merged commit 390c71b into reactphp:master Apr 4, 2017
@clue clue deleted the limit branch April 4, 2017 15:29
@clue clue mentioned this pull request Sep 4, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsor jsor jsor approved these changes

@WyriHaximus WyriHaximus WyriHaximus approved these changes

Assignees
No one assigned
Labels
new feature
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@clue @jsor @WyriHaximus
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy