[Symfony62] Replace attributes #264

JohJohan · JohJohan · commit c4c79740a9fc · 2022-11-02T10:45:09.000+01:00
diff --git a/config/sets/symfony/level/up-to-symfony-62.php b/config/sets/symfony/level/up-to-symfony-62.php
@@ -0,0 +1,11 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Rector\Symfony\Set\SymfonyLevelSetList;
+use Rector\Symfony\Set\SymfonySetList;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->sets([SymfonySetList::SYMFONY_62, SymfonyLevelSetList::UP_TO_SYMFONY_60]);
+};
diff --git a/config/sets/symfony/symfony43.php b/config/sets/symfony/symfony43.php
@@ -3,7 +3,6 @@
 declare(strict_types=1);
 
 use Rector\Arguments\Rector\ClassMethod\ArgumentAdderRector;
-
 use Rector\Arguments\ValueObject\ArgumentAdder;
 use Rector\Config\RectorConfig;
 use Rector\Core\ValueObject\MethodName;
diff --git a/config/sets/symfony/symfony60.php b/config/sets/symfony/symfony60.php
@@ -3,7 +3,6 @@
 declare(strict_types=1);
 
 use PhpParser\Node\Scalar\String_;
-
 use PHPStan\Type\MixedType;
 use PHPStan\Type\ObjectType;
 use Rector\Config\RectorConfig;
diff --git a/config/sets/symfony/symfony62.php b/config/sets/symfony/symfony62.php
@@ -0,0 +1,22 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Rector\Renaming\Rector\Name\RenameClassRector;
+
+
+return static function (RectorConfig $rectorConfig): void {
+    // https://symfony.com/blog/new-in-symfony-6-2-built-in-cache-security-template-and-doctrine-attributes
+    $rectorConfig->ruleWithConfiguration(
+        RenameClassRector::class,
+        [
+            // @see https://github.com/symfony/symfony/pull/46907
+            'Sensio\Bundle\FrameworkExtraBundle\Configuration\IsGranted' => 'Symfony\Component\Security\Http\Attribute\IsGranted',
+            // @see https://github.com/symfony/symfony/pull/46880
+            'Sensio\Bundle\FrameworkExtraBundle\Configuration\Cache' => 'Symfony\Component\HttpKernel\Attribute\Cache',
+            // @see https://github.com/symfony/symfony/pull/46906
+            'Sensio\Bundle\FrameworkExtraBundle\Configuration\Template' => 'Symfony\Bridge\Twig\Attribute\Template',
+        ],
+    );
+};
diff --git a/src/Set/SymfonyLevelSetList.php b/src/Set/SymfonyLevelSetList.php
@@ -107,4 +107,9 @@ final class SymfonyLevelSetList implements SetListInterface
      * @var string
      */
     final public const UP_TO_SYMFONY_60 = __DIR__ . '/../../config/sets/symfony/level/up-to-symfony-60.php';
+
+    /**
+     * @var string
+     */
+    final public const UP_TO_SYMFONY_62 = __DIR__ . '/../../config/sets/symfony/level/up-to-symfony-60.php';
 }
diff --git a/src/Set/SymfonySetList.php b/src/Set/SymfonySetList.php
@@ -123,6 +123,11 @@ final class SymfonySetList implements SetListInterface
      */
     final public const SYMFONY_60 = __DIR__ . '/../../config/sets/symfony/symfony60.php';
 
+    /**
+     * @var string
+     */
+    final public const SYMFONY_62 = __DIR__ . '/../../config/sets/symfony/symfony62.php';
+
     /**
      * @var string
      */
diff --git a/tests/Set/Symfony62/Fixture/replace_sensio_cache.php.inc b/tests/Set/Symfony62/Fixture/replace_sensio_cache.php.inc
@@ -0,0 +1,34 @@
+<?php
+
+use Sensio\Bundle\FrameworkExtraBundle\Configuration\Cache;
+use Symfony\Component\HttpFoundation\Response;
+use Symfony\Component\Routing\Annotation\Route;
+
+class ReplaceSensioIsCache
+{
+    #[Route('/cache', name: 'cache')]
+    #[Cache(expired: 'tomorrow')]
+    public function cache(): Response
+    {
+        return new Response();
+    }
+}
+
+?>
+-----
+<?php
+
+use Symfony\Component\HttpFoundation\Response;
+use Symfony\Component\Routing\Annotation\Route;
+
+class ReplaceSensioIsCache
+{
+    #[Route('/cache', name: 'cache')]
+    #[\Symfony\Component\HttpKernel\Attribute\Cache(expired: 'tomorrow')]
+    public function cache(): Response
+    {
+        return new Response();
+    }
+}
+
+?>
diff --git a/tests/Set/Symfony62/Fixture/replace_sensio_is_granted.php.inc b/tests/Set/Symfony62/Fixture/replace_sensio_is_granted.php.inc
@@ -0,0 +1,34 @@
+<?php
+
+use Sensio\Bundle\FrameworkExtraBundle\Configuration\IsGranted;
+use Symfony\Component\HttpFoundation\Response;
+use Symfony\Component\Routing\Annotation\Route;
+
+class ReplaceSensioIsGranted
+{
+    #[Route('/is/granted', name: 'is_granted')]
+    #[IsGranted('IS_AUTHENTICATED_FULLY')]
+    public function isGranted(): Response
+    {
+        return new Response();
+    }
+}
+
+?>
+-----
+<?php
+
+use Symfony\Component\HttpFoundation\Response;
+use Symfony\Component\Routing\Annotation\Route;
+
+class ReplaceSensioIsGranted
+{
+    #[Route('/is/granted', name: 'is_granted')]
+    #[\Symfony\Component\Security\Http\Attribute\IsGranted('IS_AUTHENTICATED_FULLY')]
+    public function isGranted(): Response
+    {
+        return new Response();
+    }
+}
+
+?>
diff --git a/tests/Set/Symfony62/Fixture/replace_sensio_template.php.inc b/tests/Set/Symfony62/Fixture/replace_sensio_template.php.inc
@@ -0,0 +1,34 @@
+<?php
+
+use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
+use Symfony\Component\HttpFoundation\Response;
+use Symfony\Component\Routing\Annotation\Route;
+
+class ReplaceSensioTemplate
+{
+    #[Route('/template', name: 'template')]
+    #[Template('templates/foo.html.twig', vars: ['bar', 'buz'])]
+    public function template($bar, $baz = 'abc', $buz = 'def'): Response
+    {
+        return new Response();
+    }
+}
+
+?>
+-----
+<?php
+
+use Symfony\Component\HttpFoundation\Response;
+use Symfony\Component\Routing\Annotation\Route;
+
+class ReplaceSensioTemplate
+{
+    #[Route('/template', name: 'template')]
+    #[\Symfony\Bridge\Twig\Attribute\Template('templates/foo.html.twig', vars: ['bar', 'buz'])]
+    public function template($bar, $baz = 'abc', $buz = 'def'): Response
+    {
+        return new Response();
+    }
+}
+
+?>
diff --git a/tests/Set/Symfony62/Symfony62Test.php b/tests/Set/Symfony62/Symfony62Test.php
@@ -0,0 +1,29 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Symfony\Tests\Set\Symfony62;
+
+use Iterator;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+
+final class Symfony62Test extends AbstractRectorTestCase
+{
+    /**
+     * @dataProvider provideData()
+     */
+    public function test(string $filePath): void
+    {
+        $this->doTestFile($filePath);
+    }
+
+    public function provideData(): Iterator
+    {
+        return $this->yieldFilesFromDirectory(__DIR__ . '/Fixture');
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/symfony62.php';
+    }
+}
diff --git a/tests/Set/Symfony62/config/symfony62.php b/tests/Set/Symfony62/config/symfony62.php
@@ -0,0 +1,11 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Rector\Symfony\Set\SymfonySetList;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->import(__DIR__ . '/../../../../config/config.php');
+    $rectorConfig->sets([SymfonySetList::SYMFONY_62]);
+};
