Use package location if one is specified #591
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrburke
added a commit
that referenced
this pull request
Jan 7, 2014
|
Thanks for pointing this out. The fix was a bit more involved, and depended on another fix that is landing for 2.1.10, so I could not use this pull request directly. However, it should be fixed for 2.1.10. |
jrburke
added a commit
to requirejs/requirejs
that referenced
this pull request
Jan 7, 2014
jrburke
added a commit
to requirejs/requirejs
that referenced
this pull request
Jan 7, 2014
jrburke
added a commit
that referenced
this pull request
Jan 7, 2014
jrburke
added a commit
to requirejs/requirejs
that referenced
this pull request
Jan 8, 2014
…mprehensive fix
jrburke
added a commit
that referenced
this pull request
Jan 8, 2014
|
Turns out there was a larger issue with compatibility with node ID resolution: they treat 'example.js' and 'example' as the same module ID. So instead of the packages-specific fix, there is a new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an issue when trying to use the package config to build a project, where the config is:
I was getting the error:
Tracing dependencies for: knex Error: ENOENT, no such file or directory '/Users/tgriesser/Github/knex/bluebird/js/main/global.js' In module tree: knex lib/raw lib/common lib/promise bluebird/js/main/promiseIn this case, it was resolving relative package paths relative to the
mainfile, which wasn't using thelocationto find the correct path. So it was doing:rather than
This pull request adds a check to see if a location is defined and if so replaces appropriately in the package name.