Processed PR feedback for symfony#57065: using ! instead of empty

rhertogh · rhertogh · commit 864b1708cd91 · 2024-05-28T18:29:35.000+02:00
diff --git a/src/Symfony/Component/Mime/Message.php b/src/Symfony/Component/Mime/Message.php
@@ -130,11 +130,11 @@ public function toIterable(): iterable
      */
     public function ensureValidity()
     {
-        if (empty($this->headers->get('To')?->getBody()) && empty($this->headers->get('Cc')?->getBody()) && empty($this->headers->get('Bcc')?->getBody())) {
+        if (!$this->headers->get('To')?->getBody() && !$this->headers->get('Cc')?->getBody() && !$this->headers->get('Bcc')?->getBody()) {
             throw new LogicException('An email must have a "To", "Cc", or "Bcc" header.');
         }
 
-        if (empty($this->headers->get('From')?->getBody()) && empty($this->headers->get('Sender')?->getBody())) {
+        if (!$this->headers->get('From')?->getBody() && !$this->headers->get('Sender')?->getBody()) {
             throw new LogicException('An email must have a "From" or a "Sender" header.');
         }
 

Original file line number	Diff line number	Diff line change
`@@ -130,11 +130,11 @@ public function toIterable(): iterable`
`130`	`130`	`*/`
`131`	`131`	`public function ensureValidity()`
`132`	`132`	`{`
`133`		`- if (empty($this->headers->get('To')?->getBody()) && empty($this->headers->get('Cc')?->getBody()) && empty($this->headers->get('Bcc')?->getBody())) {`
	`133`	`+ if (!$this->headers->get('To')?->getBody() && !$this->headers->get('Cc')?->getBody() && !$this->headers->get('Bcc')?->getBody()) {`
`134`	`134`	`throw new LogicException('An email must have a "To", "Cc", or "Bcc" header.');`
`135`	`135`	`}`
`136`	`136`
`137`		`- if (empty($this->headers->get('From')?->getBody()) && empty($this->headers->get('Sender')?->getBody())) {`
	`137`	`+ if (!$this->headers->get('From')?->getBody() && !$this->headers->get('Sender')?->getBody()) {`
`138`	`138`	`throw new LogicException('An email must have a "From" or a "Sender" header.');`
`139`	`139`	`}`
`140`	`140`