fix: fix defects according to Coverity Scan

Prcuvu · Prcuvu · commit 526a91d29544 · 2018-04-05T16:10:11.000+08:00
diff --git a/RimeWithWeasel/RimeWithWeasel.cpp b/RimeWithWeasel/RimeWithWeasel.cpp
@@ -433,7 +433,7 @@ bool RimeWithWeaselHandler::_Respond(UINT session_id, EatLine eat)
 		RimeFreeCommit(&commit);
 	}
 	
-	bool is_composing;
+	bool is_composing = false;
 	RIME_STRUCT(RimeStatus, status);
 	if (RimeGetStatus(session_id, &status))
 	{
diff --git a/WeaselDeployer/Configurator.cpp b/WeaselDeployer/Configurator.cpp
@@ -202,6 +202,7 @@ int Configurator::SyncUserData() {
 		if (!rime->sync_user_data())
 		{
 			LOG(ERROR) << "Error synching user data.";
+			CloseHandle(hMutex);
 			return 1;
 		}
 		rime->join_maintenance_thread();
diff --git a/WeaselDeployer/SwitcherSettingsDialog.cpp b/WeaselDeployer/SwitcherSettingsDialog.cpp
@@ -109,10 +109,12 @@ LRESULT SwitcherSettingsDialog::OnOK(WORD, WORD code, HWND, BOOL&) {
 			}
 		}
 		if (count == 0) {
-			MessageBox(L"至少要選用一項吧。", L"小狼毫不是這般用法", MB_OK | MB_ICONEXCLAMATION);
+			MessageBox(_T("至少要選用一項吧。"), _T("小狼毫不是這般用法"), MB_OK | MB_ICONEXCLAMATION);
+			delete selection;
 			return 0;
 		}
 		api_->select_schemas(settings_, selection, count);
+		delete selection;
 	}
 	EndDialog(code);
 	return 0;
diff --git a/WeaselServer/WeaselService.cpp b/WeaselServer/WeaselService.cpp
@@ -46,6 +46,10 @@ WeaselService::WeaselService(
 
 WeaselService::~WeaselService()
 {
+	if (_stoppedEvent != NULL)
+	{
+		CloseHandle(_stoppedEvent);
+	}
 }
 
 BOOL WeaselService::Run(WeaselService &serv)
diff --git a/WeaselSetup/imesetup.cpp b/WeaselSetup/imesetup.cpp
@@ -162,11 +162,14 @@ int register_ime(const wpath& ime_path, bool register_ime, bool is_wow64, bool h
 						DWORD len = sizeof(imeFile);
 						DWORD type = 0;
 						ret = RegQueryValueEx(hSubKey, L"Ime File", NULL, &type, (LPBYTE)imeFile, &len);
-						RegCloseKey(hSubKey);
-						if (_wcsicmp(imeFile, L"weasel.ime") == 0)
+						if (ret = ERROR_SUCCESS)
 						{
-							hKL = (HKL)k;  // already there
+							if (_wcsicmp(imeFile, L"weasel.ime") == 0)
+							{
+								hKL = (HKL)k;  // already there
+							}
 						}
+						RegCloseKey(hSubKey);
 					}
 					else
 					{
diff --git a/include/WeaselCommon.h b/include/WeaselCommon.h
@@ -29,7 +29,7 @@ namespace weasel
 
 	struct TextAttribute
 	{
-		TextAttribute() {}
+		TextAttribute() : type(NONE) {}
 		TextAttribute(int _start, int _end, TextAttributeType _type) : range(_start, _end), type(_type) {}
 		TextRange range;
 		TextAttributeType type;

Original file line number	Diff line number	Diff line change
`@@ -433,7 +433,7 @@ bool RimeWithWeaselHandler::_Respond(UINT session_id, EatLine eat)`
`433`	`433`	`RimeFreeCommit(&commit);`
`434`	`434`	`}`
`435`	`435`
`436`		`- bool is_composing;`
	`436`	`+ bool is_composing = false;`
`437`	`437`	`RIME_STRUCT(RimeStatus, status);`
`438`	`438`	`if (RimeGetStatus(session_id, &status))`
`439`	`439`	`{`
Original file line number	Diff line number	Diff line change
`@@ -202,6 +202,7 @@ int Configurator::SyncUserData() {`
`202`	`202`	`if (!rime->sync_user_data())`
`203`	`203`	`{`
`204`	`204`	`LOG(ERROR) << "Error synching user data.";`
	`205`	`+ CloseHandle(hMutex);`
`205`	`206`	`return 1;`
`206`	`207`	`}`
`207`	`208`	`rime->join_maintenance_thread();`
Original file line number	Diff line number	Diff line change
`@@ -109,10 +109,12 @@ LRESULT SwitcherSettingsDialog::OnOK(WORD, WORD code, HWND, BOOL&) {`
`109`	`109`	`}`
`110`	`110`	`}`
`111`	`111`	`if (count == 0) {`
`112`		`- MessageBox(L"至少要選用一項吧。", L"小狼毫不是這般用法", MB_OK \| MB_ICONEXCLAMATION);`
	`112`	`+ MessageBox(_T("至少要選用一項吧。"), _T("小狼毫不是這般用法"), MB_OK \| MB_ICONEXCLAMATION);`
	`113`	`+ delete selection;`
`113`	`114`	`return 0;`
`114`	`115`	`}`
`115`	`116`	`api_->select_schemas(settings_, selection, count);`
	`117`	`+ delete selection;`
`116`	`118`	`}`
`117`	`119`	`EndDialog(code);`
`118`	`120`	`return 0;`
Original file line number	Diff line number	Diff line change
`@@ -46,6 +46,10 @@ WeaselService::WeaselService(`
`46`	`46`
`47`	`47`	`WeaselService::~WeaselService()`
`48`	`48`	`{`
	`49`	`+ if (_stoppedEvent != NULL)`
	`50`	`+ {`
	`51`	`+ CloseHandle(_stoppedEvent);`
	`52`	`+ }`
`49`	`53`	`}`
`50`	`54`
`51`	`55`	`BOOL WeaselService::Run(WeaselService &serv)`
Original file line number	Diff line number	Diff line change
`@@ -162,11 +162,14 @@ int register_ime(const wpath& ime_path, bool register_ime, bool is_wow64, bool h`
`162`	`162`	`DWORD len = sizeof(imeFile);`
`163`	`163`	`DWORD type = 0;`
`164`	`164`	`ret = RegQueryValueEx(hSubKey, L"Ime File", NULL, &type, (LPBYTE)imeFile, &len);`
`165`		`- RegCloseKey(hSubKey);`
`166`		`- if (_wcsicmp(imeFile, L"weasel.ime") == 0)`
	`165`	`+ if (ret = ERROR_SUCCESS)`
`167`	`166`	`{`
`168`		`- hKL = (HKL)k; // already there`
	`167`	`+ if (_wcsicmp(imeFile, L"weasel.ime") == 0)`
	`168`	`+ {`
	`169`	`+ hKL = (HKL)k; // already there`
	`170`	`+ }`
`169`	`171`	`}`
	`172`	`+ RegCloseKey(hSubKey);`
`170`	`173`	`}`
`171`	`174`	`else`
`172`	`175`	`{`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ namespace weasel`
`29`	`29`
`30`	`30`	`struct TextAttribute`
`31`	`31`	`{`
`32`		`- TextAttribute() {}`
	`32`	`+ TextAttribute() : type(NONE) {}`
`33`	`33`	`TextAttribute(int _start, int _end, TextAttributeType _type) : range(_start, _end), type(_type) {}`
`34`	`34`	`TextRange range;`
`35`	`35`	`TextAttributeType type;`