Skip to content

Commit 21ae36a

Browse files
rnpridgeonRyan P
authored andcommitted
Misc cleanup for docs and exception messages
1 parent d31caba commit 21ae36a

File tree

3 files changed

+12
-12
lines changed

3 files changed

+12
-12
lines changed

confluent_kafka/schema_registry/schema_registry_client.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,8 @@ def __init__(self, conf):
114114

115115
# Any leftover keys are unknown to _RestClient
116116
if len(conf_copy) > 0:
117-
raise ValueError("Unrecognized properties: {}".format(conf_copy.keys()))
117+
raise ValueError("Unrecognized properties: {}"
118+
.format(", ".join(conf_copy.keys())))
118119

119120
def _close(self):
120121
self.session.close()

tests/integration/serialization/test_serializers.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -37,12 +37,12 @@ def test_numeric_serialization(kafka_cluster, serializer, deserializer, data):
3737
3838
Args:
3939
kafka_cluster (KafkaClusterFixture): cluster fixture
40+
4041
serializer (Serializer): serializer to test
42+
4143
deserializer (Deserializer): deserializer to validate serializer
42-
data(object(: input data
4344
44-
Raises:
45-
AssertionError on test failure
45+
data(object): input data
4646
4747
"""
4848
topic = kafka_cluster.create_topic("serialization-numeric")
@@ -71,11 +71,10 @@ def test_string_serialization(kafka_cluster, data, codec):
7171
7272
Args:
7373
kafka_cluster (KafkaClusterFixture): cluster fixture
74+
7475
data (unicode): input data
75-
codec (str): encoding type
7676
77-
Raises:
78-
AssertionError on test failure
77+
codec (str): encoding type
7978
8079
"""
8180
topic = kafka_cluster.create_topic("serialization-string")
@@ -110,13 +109,14 @@ def test_mixed_serialization(kafka_cluster, key_serializer, value_serializer,
110109
111110
Args:
112111
kafka_cluster (KafkaClusterFixture): cluster fixture
112+
113113
key_serializer (Serializer): serializer to test
114+
114115
key_deserializer (Deserializer): deserializer to validate serializer
116+
115117
key (object): key data
116-
value (object): value data
117118
118-
Raises:
119-
AssertionError on test failure
119+
value (object): value data
120120
121121
"""
122122
topic = kafka_cluster.create_topic("serialization-numeric")

tests/schema_registry/test_config.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,5 @@ def test_config_unknown_prop():
132132
'invalid.conf': 1,
133133
'invalid.conf2': 2}
134134

135-
with pytest.raises(ValueError, match=r"Unrecognized properties:"
136-
r" (\[(.*)\])$"):
135+
with pytest.raises(ValueError, match=r"Unrecognized properties: (.*)"):
137136
SchemaRegistryClient(conf)

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy