Fixed exit_code issue in pipeline.rs

rohitcoder · rohitcoder · commit 58b7e41e7408 · 2024-08-27T17:34:19.000+05:30
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -28,4 +28,4 @@ jobs:
           context: .
           file: ./Dockerfile
           push: true
-          tags: ${{ secrets.DOCKERHUB_USERNAME }}/hela:v5
+          tags: ${{ secrets.DOCKERHUB_USERNAME }}/hela:v6
diff --git a/src/utils/common.rs b/src/utils/common.rs
@@ -197,7 +197,6 @@ pub async fn insert_job_info(
         .into_iter()
         .map(|v| to_bson(&v).unwrap_or(Bson::Null))
         .collect();
-
     // Create the document to insert
     let document = doc! {
         "job_id": job_id,
diff --git a/src/utils/pipeline.rs b/src/utils/pipeline.rs
@@ -951,8 +951,10 @@ pub async fn pipeline_failure(
                     }
                 }
             }
-            exit_code = common::EXIT_CODE_SAST_FAILED;
-            exit_msg = common::SAST_FAILED_MSG.to_string();
+            if is_pipeline_failed {
+                exit_code = common::EXIT_CODE_SAST_FAILED;
+                exit_msg = common::SAST_FAILED_MSG.to_string();
+            }
         }
 
         if is_sca && sca_policy.is_some() {
@@ -999,8 +1001,10 @@ pub async fn pipeline_failure(
                     }
                 }
             }
-            exit_code = common::EXIT_CODE_SCA_FAILED;
-            exit_msg = common::SCA_FAILED_MSG.to_string();
+            if is_pipeline_failed {
+                exit_code = common::EXIT_CODE_SCA_FAILED;
+                exit_msg = common::SCA_FAILED_MSG.to_string();
+            }
         }
 
         if is_secret && secret_policy.is_some() {
@@ -1056,9 +1060,10 @@ pub async fn pipeline_failure(
                     }
                 }
             }
-
-            exit_code = common::EXIT_CODE_SECRET_FAILED;
-            exit_msg = common::SECRET_FAILED_MSG.to_string();
+            if is_pipeline_failed {
+                exit_code = common::EXIT_CODE_SECRET_FAILED;
+                exit_msg = common::SECRET_FAILED_MSG.to_string();
+            }
         }
         if is_license_compliance && license_policy.is_some() {
             let license_policy = license_policy.unwrap().as_mapping().unwrap();
@@ -1083,8 +1088,10 @@ pub async fn pipeline_failure(
                     }
                 }
             }
-            exit_code = common::EXIT_CODE_LICENSE_FAILED;
-            exit_msg = common::LICENSE_FAILED_MSG.to_string();
+            if is_pipeline_failed {
+                exit_code = common::EXIT_CODE_LICENSE_FAILED;
+                exit_msg = common::LICENSE_FAILED_MSG.to_string();
+            }
         }
         if is_pipeline_failed {
             println!("\n\n");

Original file line number	Diff line number	Diff line change
`@@ -951,8 +951,10 @@ pub async fn pipeline_failure(`
`951`	`951`	`}`
`952`	`952`	`}`
`953`	`953`	`}`
`954`		`- exit_code = common::EXIT_CODE_SAST_FAILED;`
`955`		`- exit_msg = common::SAST_FAILED_MSG.to_string();`
	`954`	`+ if is_pipeline_failed {`
	`955`	`+ exit_code = common::EXIT_CODE_SAST_FAILED;`
	`956`	`+ exit_msg = common::SAST_FAILED_MSG.to_string();`
	`957`	`+ }`
`956`	`958`	`}`
`957`	`959`
`958`	`960`	`if is_sca && sca_policy.is_some() {`
`@@ -999,8 +1001,10 @@ pub async fn pipeline_failure(`
`999`	`1001`	`}`
`1000`	`1002`	`}`
`1001`	`1003`	`}`
`1002`		`- exit_code = common::EXIT_CODE_SCA_FAILED;`
`1003`		`- exit_msg = common::SCA_FAILED_MSG.to_string();`
	`1004`	`+ if is_pipeline_failed {`
	`1005`	`+ exit_code = common::EXIT_CODE_SCA_FAILED;`
	`1006`	`+ exit_msg = common::SCA_FAILED_MSG.to_string();`
	`1007`	`+ }`
`1004`	`1008`	`}`
`1005`	`1009`
`1006`	`1010`	`if is_secret && secret_policy.is_some() {`
`@@ -1056,9 +1060,10 @@ pub async fn pipeline_failure(`
`1056`	`1060`	`}`
`1057`	`1061`	`}`
`1058`	`1062`	`}`
`1059`		`-`
`1060`		`- exit_code = common::EXIT_CODE_SECRET_FAILED;`
`1061`		`- exit_msg = common::SECRET_FAILED_MSG.to_string();`
	`1063`	`+ if is_pipeline_failed {`
	`1064`	`+ exit_code = common::EXIT_CODE_SECRET_FAILED;`
	`1065`	`+ exit_msg = common::SECRET_FAILED_MSG.to_string();`
	`1066`	`+ }`
`1062`	`1067`	`}`
`1063`	`1068`	`if is_license_compliance && license_policy.is_some() {`
`1064`	`1069`	`let license_policy = license_policy.unwrap().as_mapping().unwrap();`
`@@ -1083,8 +1088,10 @@ pub async fn pipeline_failure(`
`1083`	`1088`	`}`
`1084`	`1089`	`}`
`1085`	`1090`	`}`
`1086`		`- exit_code = common::EXIT_CODE_LICENSE_FAILED;`
`1087`		`- exit_msg = common::LICENSE_FAILED_MSG.to_string();`
	`1091`	`+ if is_pipeline_failed {`
	`1092`	`+ exit_code = common::EXIT_CODE_LICENSE_FAILED;`
	`1093`	`+ exit_msg = common::LICENSE_FAILED_MSG.to_string();`
	`1094`	`+ }`
`1088`	`1095`	`}`
`1089`	`1096`	`if is_pipeline_failed {`
`1090`	`1097`	`println!("\n\n");`