Stop recommending node-builtins (#4190)

curran · web-flow · commit b1c4a17feba8 · 2021-07-25T07:12:14.000+02:00
* Stop recommending node-builtins. Closes #2881 * Update all occurrences of node-polyfills.
diff --git a/cli/run/batchWarnings.ts b/cli/run/batchWarnings.ts
@@ -78,7 +78,7 @@ const immediateHandlers: {
 		stderr(
 			`Creating a browser bundle that depends on ${printQuotedStringList(
 				warning.modules!
-			)}. You might need to include https://github.com/ionic-team/rollup-plugin-node-polyfills`
+			)}. You might need to include https://github.com/snowpackjs/rollup-plugin-polyfill-node`
 		);
 	},
 
diff --git a/docs/08-troubleshooting.md b/docs/08-troubleshooting.md
@@ -91,7 +91,7 @@ export default {
 
 If you *do* want to include the module in your bundle, you need to tell Rollup how to find it. In most cases, this is a question of using [@rollup/plugin-node-resolve](https://github.com/rollup/plugins/tree/master/packages/node-resolve).
 
-Some modules, like `events` or `util`, are built in to Node.js. If you want to include those (for example, so that your bundle runs in the browser), you may need to include [rollup-plugin-node-polyfills](https://github.com/ionic-team/rollup-plugin-node-polyfills).
+Some modules, like `events` or `util`, are built in to Node.js. If you want to include those (for example, so that your bundle runs in the browser), you may need to include [rollup-plugin-polyfill-node](https://github.com/snowpackjs/rollup-plugin-polyfill-node).
 
 ### Error: "EMFILE: too many open files"
 
diff --git a/src/finalisers/shared/warnOnBuiltins.ts b/src/finalisers/shared/warnOnBuiltins.ts
@@ -38,7 +38,7 @@ export default function warnOnBuiltins(
 		code: 'MISSING_NODE_BUILTINS',
 		message: `Creating a browser bundle that depends on Node.js built-in modules (${printQuotedStringList(
 			externalBuiltins
-		)}). You might need to include https://github.com/ionic-team/rollup-plugin-node-polyfills`,
+		)}). You might need to include https://github.com/snowpackjs/rollup-plugin-polyfill-node`,
 		modules: externalBuiltins
 	});
 }
diff --git a/test/cli/samples/warn-multiple/_config.js b/test/cli/samples/warn-multiple/_config.js
@@ -7,7 +7,7 @@ module.exports = {
 		assertIncludes(
 			stderr,
 			'(!) Missing shims for Node.js built-ins\n' +
-				'Creating a browser bundle that depends on "url", "assert" and "path". You might need to include https://github.com/ionic-team/rollup-plugin-node-polyfills\n'
+				'Creating a browser bundle that depends on "url", "assert" and "path". You might need to include https://github.com/snowpackjs/rollup-plugin-polyfill-node\n'
 		);
 		assertIncludes(
 			stderr,
diff --git a/test/misc/misc.js b/test/misc/misc.js
@@ -49,7 +49,7 @@ describe('misc', () => {
 				assert.equal(relevantWarnings.length, 1);
 				assert.equal(
 					relevantWarnings[0].message,
-					`Creating a browser bundle that depends on Node.js built-in modules ("util"). You might need to include https://github.com/ionic-team/rollup-plugin-node-polyfills`
+					`Creating a browser bundle that depends on Node.js built-in modules ("util"). You might need to include https://github.com/snowpackjs/rollup-plugin-polyfill-node`
 				);
 			});
 	});

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ export default function warnOnBuiltins(`
`38`	`38`	`code: 'MISSING_NODE_BUILTINS',`
`39`	`39`	message: `Creating a browser bundle that depends on Node.js built-in modules (${printQuotedStringList(
`40`	`40`	`externalBuiltins`
`41`		- )}). You might need to include https://github.com/ionic-team/rollup-plugin-node-polyfills`,
	`41`	+ )}). You might need to include https://github.com/snowpackjs/rollup-plugin-polyfill-node`,
`42`	`42`	`modules: externalBuiltins`
`43`	`43`	`});`
`44`	`44`	`}`