Added ability to set proxy to http #570
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added proxy #208 |
benlangfeld
reviewed
Oct 1, 2020
| @@ -6,6 +6,7 @@ def initialize(app, delivery_class, _options = {}) | |||
| @app = app | |||
| @delivery_class = delivery_class | |||
| @http = Net::HTTP::Persistent.new(name: 'rpush') | |||
| @http.proxy = Rpush.config.proxy if Rpush.config.proxy.present? | |||
There was a problem hiding this comment.
This only applies to HTTP dispatchers, and does not contemplate APNSv2/p8. Could you maybe add it to those dispatchers also?
There was a problem hiding this comment.
Sorry but I didn't use APNS, so I cannot test it
There was a problem hiding this comment.
Would a spec not be enough to create confidence in its functionality?
|
This issue has been automatically marked as stale because it has not had recent activity. If this is still an issue, please leave another comment. This issue will be closed if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.