Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rt-net/rt_usb_9axisimu_driver
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2.1.0
Choose a base ref
...
head repository: rt-net/rt_usb_9axisimu_driver
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 3.0.0
Choose a head ref
  • 8 commits
  • 10 files changed
  • 4 contributors

Commits on Apr 5, 2024

  1. Add unit tests (#52)

    * Use pointer for SerialPort instance instead of inheritance
    
    * Add test using fakeit
    
    * Install git comand in indsutrial_ci
    
    * Refactoring
    
    * Update CI
    
    * Use AFTER_SETUP_TARGET_WORKSPACE
    
    * driverインスタンスのメンバ変数のテストを追加
    
    * バイナリデータが読み込まれたことを確認するテストを追加
    
    * ASCIIデータが読み込まれたことを確認するテストを追加
    
    * バイナリでもASCIIでもないデータが読み込まれたことを確認するテストを追加
    
    * テストが通る状態に修正
    
    ---------
    
    Co-authored-by: ShotaAk <s.aoki@rt-net.jp>
    YusukeKato and ShotaAk committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    faf39b0 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. checkDataFormat() and unit test updates (#54)

    * Binaryデータ出力時は実機とテストの両方で動作確認完了、ASCIIデータには未対応、デバッグ用出力あり
    
    * 実機とテストの両方でBinaryとASCIIの判定に成功、BinaryでもASCIIでもないデータには未対応
    
    * タイムアウト機能を追加&hasCompletedFormatCheck()と関係する変数を削除
    
    * 不正なデータをチェックするようにテストを修正
    
    * readを成功させるためにwhileループにsleep処理を追加
    
    * 必要がなかったため、while文のsleep処理を削除
    
    * テスト用データの作成で重複している箇所を関数化
    
    * RCLCPP_INFOをWARNに変更&不要なコメントを削除
    
    * const autoをできる限り使用
    
    * actions/checkoutのバージョンを3から4に更新
    
    * 読み取ったデータをある程度貯めてからデータ形式を判定するように変更
    
    * 貯めるデータを更新するように修正
    
    * メンバ変数の名前を修正&256を定数化
    YusukeKato authored Aug 6, 2024
    Configuration menu
    Copy the full SHA
    b22d060 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. Add test for readSensorData() (#57)

    * readSensorData()実行後のhasRefreshedImuData()の応答のテストを追加
    
    * テストにコメントを追加
    
    * 0.0を入力として与えたテストを追加
    
    * ASCII形式のテストデータを作成する際、引数で値を渡せるように変更
    
    * Binary形式でもテストデータを引数で渡せるように変更
    
    * テストケースを使い回せるように変更
    
    * readSensorData()実行時にセンサデータが正しく変換されたか検証するテストを追加
    
    * デバッグ用の関数を削除
    
    * short intをint16_tに変更
    
    * int16を8bitずつに分ける関数をhighとlowそれぞれ用意
    
    * 既存のテストに影響を与えないようにデータ作成の関数をオーバーロード
    
    * set_data関数をprivateに変更
    
    * 変換後の数値を直打ち
    
    * data_format_を設定する関数を削除
    
    * 不要な箇所を削除
    YusukeKato authored Aug 20, 2024
    Configuration menu
    Copy the full SHA
    c63da0b View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. Fix to get the latest data (#58)

    * 最新データ取得のテストを追加
    
    * PR#50を参考に最新のデータを取得できるように変更
    
    * 複数セットのデータ取得時に最新のデータをセットするように変更、テストは通るが挙動がおかしい
    
    * 最新データの取得方法を修正
    
    * 取得するデータが適切な長さであることを保証する
    YusukeKato authored Aug 21, 2024
    Configuration menu
    Copy the full SHA
    6d58d47 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. 2.1.0リリースのためにCHANGELOG.rstとpackage.xmlを更新 (#59)

    * CHANGELOGを更新
    
    * 2.1.0
    YusukeKato authored Aug 23, 2024
    Configuration menu
    Copy the full SHA
    806ca07 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. ROS 2 Jazzyへの対応 (#61)

    * fix "ROS_DISTRO"  of CI for Jazzy
    
    * Add authors
    
    * Update README for Jazzy
    
    * Modify CI to ensure compatibility with the act tool
    
    * Add messages of compiler version message for debug
    
    * add ccache setting
    
    * Set log level "debug" for CI
    
    * comment out env for debug
    
    * Replace  "ROS_REPO: [ros]" with "ROS_REPO: [main]" for CI of "ROS 2"
    
    * Fix undefined behavior by storing `std::string` objects instead of `const char*` pointers
    Previously, the test code for the 9-axis IMU was storing `const char*` pointers obtained from temporary `std::string` objects into a vector. Since these temporary `std::string` objects are destroyed immediately after the expression, the stored pointers became invalid (dangling pointers), leading to undefined behavior and causing tests to fail.
    This commit fixes the issue by changing the vector to store *std::string* objects directly instead of `const char*` pointers. By maintaining the `std::string` objects, we ensure that the data remains valid throughout its usage, and any `c_str()` calls on these strings return valid pointers.
    
    This change resolves the test failures and prevents potential crashes or incorrect data processing due to invalid memory access.
    
    * Update copyright year
    KuraZuzu authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    9138e0d View commit details
    Browse the repository at this point in the history
  2. ROS 2 RollingへのCI対応 (#62)

    * Update CI for ROS 2 Rolling
    
    * Summarize setting "AFTER_SETUP_TARGET_WORKSPACE"
    KuraZuzu authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    6ffb0a9 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. リリース3.0.0への対応 (#63)

    * Update CHANGELOG.rst
    
    * Update release version
    
    * Fix PR links
    
    * Fix date
    KuraZuzu authored Nov 7, 2024
    Configuration menu
    Copy the full SHA
    3766c9c View commit details
    Browse the repository at this point in the history
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy