Merge pull request #14343 from koic/fix_autocorrect_for_style_hash_conversion

koic · web-flow · commit 0b08bb87f150 · 2025-07-07T00:11:25.000+09:00
Fix autocorrect for `Style/HashConversion` to avoid syntax error
diff --git a/changelog/fix_autocorrect_for_style_hash_conversion.md b/changelog/fix_autocorrect_for_style_hash_conversion.md
@@ -0,0 +1 @@
+* [#14343](https://github.com/rubocop/rubocop/pull/14343): Fix autocorrect code for `Style/HashConversion` to avoid syntax error. ([@koic][])
diff --git a/lib/rubocop/cop/style/hash_conversion.rb b/lib/rubocop/cop/style/hash_conversion.rb
@@ -128,7 +128,9 @@ def multi_argument(node)
               corrector.replace(node, args_to_hash(node.arguments))
 
               parent = node.parent
-              add_parentheses(parent, corrector) if parent&.send_type? && !parent.parenthesized?
+              if parent&.send_type? && !parent.method?(:to_h) && !parent.parenthesized?
+                add_parentheses(parent, corrector)
+              end
             end
           end
         end
diff --git a/spec/rubocop/cop/style/hash_conversion_spec.rb b/spec/rubocop/cop/style/hash_conversion_spec.rb
@@ -208,6 +208,17 @@
     RUBY
   end
 
+  it 'reports an offense for `Hash[].to_h`' do
+    expect_offense(<<~RUBY)
+      Hash[].to_h
+      ^^^^^^ Prefer literal hash to `Hash[arg1, arg2, ...]`.
+    RUBY
+
+    expect_correction(<<~RUBY)
+      {}.to_h
+    RUBY
+  end
+
   context 'AllowSplatArgument: true' do
     let(:cop_config) { { 'AllowSplatArgument' => true } }
 

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+* [#14343](https://github.com/rubocop/rubocop/pull/14343): Fix autocorrect code for `Style/HashConversion` to avoid syntax error. ([@koic][])