Fix false positives for Style/RedundantDoubleSplatHashBraces

koic · bbatsov · commit 128618c7a8e3 · 2023-10-12T11:29:09.000+02:00
Fixes #12263. This PR fixes false positives for `Style/RedundantDoubleSplatHashBraces` when method call for no hash braced double splat receiver. The code shown in #12263 is incompatible as shown below and is a false positive: ```ruby def x(opts) = puts(opts) h = {foo: :bar} x(**h.merge(k: :h)) #=> {:foo=>:bar, :k=>:h} x(k: :v, **h) #=> {:k=>:v, :foo=>:bar} ```
diff --git a/changelog/fix_false_positive_for_style_redundant_double_splat_hash_braces.md b/changelog/fix_false_positive_for_style_redundant_double_splat_hash_braces.md
@@ -0,0 +1 @@
+* [#12263](https://github.com/rubocop/rubocop/issues/12263): Fix false positives for `Style/RedundantDoubleSplatHashBraces` when method call for no hash braced double splat receiver. ([@koic][])
diff --git a/lib/rubocop/cop/style/redundant_double_splat_hash_braces.rb b/lib/rubocop/cop/style/redundant_double_splat_hash_braces.rb
@@ -27,10 +27,11 @@ class RedundantDoubleSplatHashBraces < Base
 
         # rubocop:disable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
         def on_hash(node)
-          return if !node.braces? || node.pairs.empty? || node.pairs.any?(&:hash_rocket?)
+          return if node.pairs.empty? || node.pairs.any?(&:hash_rocket?)
           return unless (parent = node.parent)
-          return unless (kwsplat = node.each_ancestor(:kwsplat).first)
           return if parent.call_type? && !merge_method?(parent)
+          return unless (kwsplat = node.each_ancestor(:kwsplat).first)
+          return if allowed_double_splat_receiver?(kwsplat)
 
           add_offense(kwsplat) do |corrector|
             autocorrect(corrector, node, kwsplat)
@@ -40,6 +41,14 @@ def on_hash(node)
 
         private
 
+        def allowed_double_splat_receiver?(kwsplat)
+          return false unless kwsplat.children.first.call_type?
+
+          root_receiver = root_receiver(kwsplat.children.first)
+
+          !root_receiver&.hash_type?
+        end
+
         def autocorrect(corrector, node, kwsplat)
           corrector.remove(kwsplat.loc.operator)
           corrector.remove(opening_brace(node))
@@ -51,6 +60,15 @@ def autocorrect(corrector, node, kwsplat)
           autocorrect_merge_methods(corrector, merge_methods, kwsplat)
         end
 
+        def root_receiver(node)
+          receiver = node.receiver
+          if receiver&.receiver
+            root_receiver(receiver)
+          else
+            receiver
+          end
+        end
+
         def select_merge_method_nodes(kwsplat)
           extract_send_methods(kwsplat).select do |node|
             merge_method?(node)
diff --git a/spec/rubocop/cop/style/redundant_double_splat_hash_braces_spec.rb b/spec/rubocop/cop/style/redundant_double_splat_hash_braces_spec.rb
@@ -138,6 +138,18 @@
     RUBY
   end
 
+  it 'does not register an offense when method call for no hash braced double splat receiver' do
+    expect_no_offenses(<<~RUBY)
+      do_something(**options.merge({foo: bar}))
+    RUBY
+  end
+
+  it 'does not register an offense when safe navigation method call for no hash braced double splat receiver' do
+    expect_no_offenses(<<~RUBY)
+      do_something(**options&.merge({foo: bar}))
+    RUBY
+  end
+
   it 'does not register an offense when using empty double splat hash braces arguments' do
     expect_no_offenses(<<~RUBY)
       do_something(**{})

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+* [#12263](https://github.com/rubocop/rubocop/issues/12263): Fix false positives for `Style/RedundantDoubleSplatHashBraces` when method call for no hash braced double splat receiver. ([@koic][])