Merge pull request #13972 from dvandersluis/issue/13965た

koic · web-flow · commit 5695986cf410 · 2025-03-11T05:53:30.000+09:00
[Fix #13965] Update `Lint/RedundantCopDisableDirective` to register an offense when cop names are given with improper casing
diff --git a/changelog/fix_update_lint_redundant_cop_disable_directive_to_20250310151635.md b/changelog/fix_update_lint_redundant_cop_disable_directive_to_20250310151635.md
@@ -0,0 +1 @@
+* [#13965](https://github.com/rubocop/rubocop/issues/13965): Update `Lint/RedundantCopDisableDirective` to register an offense when cop names are given with improper casing. ([@dvandersluis][])
diff --git a/lib/rubocop/directive_comment.rb b/lib/rubocop/directive_comment.rb
@@ -12,7 +12,7 @@ class DirectiveComment
     # @api private
     LINT_SYNTAX_COP = "#{LINT_DEPARTMENT}/Syntax"
     # @api private
-    COP_NAME_PATTERN = '([A-Z]\w+/)*(?:[A-Z]\w+)'
+    COP_NAME_PATTERN = '([A-Za-z]\w+/)*(?:[A-Za-z]\w+)'
     # @api private
     COP_NAMES_PATTERN = "(?:#{COP_NAME_PATTERN} , )*#{COP_NAME_PATTERN}"
     # @api private
diff --git a/spec/rubocop/cop/lint/redundant_cop_disable_directive_spec.rb b/spec/rubocop/cop/lint/redundant_cop_disable_directive_spec.rb
@@ -266,6 +266,28 @@
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ #{message}
               RUBY
             end
+
+            context 'when the department starts with a lowercase letter' do
+              it 'registers an offense' do
+                expect_offense(<<~RUBY)
+                  # rubocop:disable lint/SelfAssignment
+                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Unnecessary disabling of `lint/SelfAssignment` (did you mean `Lint/SelfAssignment`?).
+                RUBY
+
+                expect_correction('')
+              end
+            end
+
+            context 'when the cop starts with a lowercase letter' do
+              it 'registers an offense' do
+                expect_offense(<<~RUBY)
+                  # rubocop:disable Lint/selfAssignment
+                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Unnecessary disabling of `Lint/selfAssignment` (did you mean `Lint/SelfAssignment`?).
+                RUBY
+
+                expect_correction('')
+              end
+            end
           end
 
           context 'all cops' do

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+* [#13965](https://github.com/rubocop/rubocop/issues/13965): Update `Lint/RedundantCopDisableDirective` to register an offense when cop names are given with improper casing. ([@dvandersluis][])