Skip to content

Commit 815dcca

Browse files
committed
Cut 1.73.2
1 parent 398aaab commit 815dcca

File tree

9 files changed

+34
-16
lines changed

9 files changed

+34
-16
lines changed

.github/ISSUE_TEMPLATE/bug_report.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ output by `rubocop -V`, include them as well. Here's an example:
3939

4040
```
4141
$ [bundle exec] rubocop -V
42-
1.73.1 (using Parser 3.3.5.0, rubocop-ast 1.32.3, analyzing as Ruby 3.3, running on ruby 3.3.5) [x86_64-linux]
42+
1.73.2 (using Parser 3.3.5.0, rubocop-ast 1.32.3, analyzing as Ruby 3.3, running on ruby 3.3.5) [x86_64-linux]
4343
- rubocop-performance 1.22.1
4444
- rubocop-rspec 3.1.0
4545
```

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@
1111

1212
## master (unreleased)
1313

14+
## 1.73.2 (2025-03-04)
15+
1416
### Bug fixes
1517

1618
* [#13942](https://github.com/rubocop/rubocop/pull/13942): Fix incorrect disabling of departments when inheriting configuration. ([@koic][])

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ do so.
1717

1818
```console
1919
$ rubocop -V
20-
1.73.1 (using Parser 3.3.5.0, rubocop-ast 1.32.3, analyzing as Ruby 3.3, running on ruby 3.3.5) [x86_64-linux]
20+
1.73.2 (using Parser 3.3.5.0, rubocop-ast 1.32.3, analyzing as Ruby 3.3, running on ruby 3.3.5) [x86_64-linux]
2121
- rubocop-performance 1.22.1
2222
- rubocop-rspec 3.1.0
2323
```

config/default.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1889,7 +1889,7 @@ Lint/EmptyConditionalBody:
18891889
AutoCorrect: contextual
18901890
AllowComments: true
18911891
VersionAdded: '0.89'
1892-
VersionChanged: '<<next>>'
1892+
VersionChanged: '1.73'
18931893

18941894
Lint/EmptyEnsure:
18951895
Description: 'Checks for empty ensure block.'

docs/antora.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@ name: rubocop
22
title: RuboCop
33
# We always provide version without patch here (e.g. 1.1),
44
# as patch versions should not appear in the docs.
5-
version: ~
5+
version: '1.73'
66
nav:
77
- modules/ROOT/nav.adoc

docs/modules/ROOT/pages/cops_lint.adoc

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2257,22 +2257,15 @@ end
22572257
22582258
| Enabled
22592259
| Yes
2260-
| Command-line only (Unsafe)
2260+
| Command-line only
22612261
| 0.89
2262-
| 1.61
2262+
| 1.73
22632263
|===
22642264
22652265
Checks for the presence of `if`, `elsif` and `unless` branches without a body.
22662266
22672267
NOTE: empty `else` branches are handled by `Style/EmptyElse`.
22682268
2269-
[#safety-lintemptyconditionalbody]
2270-
=== Safety
2271-
2272-
Autocorrection for this cop is not safe. The conditions for empty branches that
2273-
the autocorrection removes may have side effects, or the logic in subsequent
2274-
branches may change due to the removal of a previous condition.
2275-
22762269
[#examples-lintemptyconditionalbody]
22772270
=== Examples
22782271
@@ -2302,6 +2295,13 @@ unless condition
23022295
do_something
23032296
end
23042297
2298+
# good
2299+
if condition
2300+
do_something
2301+
elsif other_condition
2302+
nil
2303+
end
2304+
23052305
# good
23062306
if condition
23072307
do_something

docs/modules/ROOT/pages/integration_with_other_tools.adoc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ following to your `.pre-commit-config.yaml` file:
125125
[source,yaml]
126126
----
127127
- repo: https://github.com/rubocop/rubocop
128-
rev: v1.73.1
128+
rev: v1.73.2
129129
hooks:
130130
- id: rubocop
131131
----
@@ -136,7 +136,7 @@ entries in `additional_dependencies`:
136136
[source,yaml]
137137
----
138138
- repo: https://github.com/rubocop/rubocop
139-
rev: v1.73.1
139+
rev: v1.73.2
140140
hooks:
141141
- id: rubocop
142142
additional_dependencies:

lib/rubocop/version.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
module RuboCop
44
# This module holds the RuboCop version information.
55
module Version
6-
STRING = '1.73.1'
6+
STRING = '1.73.2'
77

88
MSG = '%<version>s (using %<parser_version>s, ' \
99
'rubocop-ast %<rubocop_ast_version>s, ' \

relnotes/v1.73.2.md

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
### Bug fixes
2+
3+
* [#13942](https://github.com/rubocop/rubocop/pull/13942): Fix incorrect disabling of departments when inheriting configuration. ([@koic][])
4+
* [#13766](https://github.com/rubocop/rubocop/issues/13766): Fix false positives for `Style/InverseMethods` when using `any?` or `none?` with safe navigation operator. ([@koic][])
5+
* [#13938](https://github.com/rubocop/rubocop/pull/13938): Fix false positives for `Style/RedundantCondition` when a variable or a constant is used. ([@koic][])
6+
* [#13935](https://github.com/rubocop/rubocop/pull/13935): Fix a false negative for `Style/RedundantFreeze` when calling methods that produce frozen objects with numblocks. ([@earlopain][])
7+
* [#13928](https://github.com/rubocop/rubocop/issues/13928): Fix `end pattern with unmatched parenthesis: / (RegexpError)` on Ruby 3.2.0. ([@dvandersluis][])
8+
* [#13933](https://github.com/rubocop/rubocop/issues/13933): Fix wrong autocorrect for `Style/KeywordParametersOrder` when the arguments are on multiple lines and contain comments. ([@earlopain][])
9+
10+
### Changes
11+
12+
* [#12669](https://github.com/rubocop/rubocop/issues/12669): Update autocorrection for `Lint/EmptyConditionalBody` to be safe. ([@dvandersluis][])
13+
14+
[@koic]: https://github.com/koic
15+
[@earlopain]: https://github.com/earlopain
16+
[@dvandersluis]: https://github.com/dvandersluis

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy