Merge pull request #13783 from Earlopain/lint-void-numblock

koic · web-flow · commit 933c8799b20e · 2025-02-01T20:32:52.000+09:00
Fix a false positive for `Lint/Void` when `each` numblock with conditional expressions that has multiple statements
diff --git a/changelog/fix_false_positive_lint_void_numblock.md b/changelog/fix_false_positive_lint_void_numblock.md
@@ -0,0 +1 @@
+* [#13783](https://github.com/rubocop/rubocop/pull/13783): Fix a false positive for `Lint/Void` when `each` numblock with conditional expressions that has multiple statements. ([@earlopain][])
diff --git a/lib/rubocop/cop/lint/void.rb b/lib/rubocop/cop/lint/void.rb
@@ -103,7 +103,7 @@ def check_begin(node)
           expressions.pop unless in_void_context?(node)
           expressions.each do |expr|
             check_void_op(expr) do
-              block_node = node.each_ancestor(:block).first
+              block_node = node.each_ancestor(:any_block).first
 
               block_node&.method?(:each)
             end
@@ -201,11 +201,6 @@ def check_ensure(node)
           # NOTE: the `begin` node case is already handled via `on_begin`
           return if body.begin_type?
 
-          check_void_op(body) do
-            block_node = node.each_ancestor(:block).first
-            block_node&.method?(:each)
-          end
-
           check_expression(body)
         end
 
diff --git a/spec/rubocop/cop/lint/void_spec.rb b/spec/rubocop/cop/lint/void_spec.rb
@@ -894,6 +894,18 @@ def self.foo=(rhs)
     RUBY
   end
 
+  it 'does not register `#each` numblock with conditional expressions that has multiple statements' do
+    expect_no_offenses(<<~RUBY)
+      enumerator_as_filter.each do
+        puts _1
+
+        # The `filter` method is used to filter for matches with `42`.
+        # In this case, it's not void.
+        _1 == 42
+      end
+    RUBY
+  end
+
   context 'Ruby 2.7', :ruby27 do
     it 'registers two offenses for void literals in `#tap` method' do
       expect_offense(<<~RUBY)

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+* [#13783](https://github.com/rubocop/rubocop/pull/13783): Fix a false positive for `Lint/Void` when `each` numblock with conditional expressions that has multiple statements. ([@earlopain][])