Merge pull request #12773 from Earlopain/fix-error-for-style-for

koic · web-flow · commit 9b39a559883b · 2024-03-11T05:40:34.000+09:00
Fix an error for `Style/For` with `EnforcedStyle: for` when no receiver
diff --git a/changelog/fix_an_error_for_style_for.md b/changelog/fix_an_error_for_style_for.md
@@ -0,0 +1 @@
+* [#12773](https://github.com/rubocop/rubocop/pull/12773): Fix an error for `Style/For` with `EnforcedStyle: for` when no receiver. ([@earlopain][])
diff --git a/lib/rubocop/cop/style/for.rb b/lib/rubocop/cop/style/for.rb
@@ -66,6 +66,8 @@ def on_block(node)
           return unless suspect_enumerable?(node)
 
           if style == :for
+            return unless node.receiver
+
             add_offense(node, message: PREFER_FOR) do |corrector|
               EachToForCorrector.new(node).call(corrector)
               opposite_style_detected
diff --git a/spec/rubocop/cop/style/for_spec.rb b/spec/rubocop/cop/style/for_spec.rb
@@ -488,6 +488,14 @@ def func
       RUBY
     end
 
+    it 'registers no offense when there is no receiver' do
+      expect_no_offenses(<<~RUBY)
+        each do |n|
+          puts n
+        end
+      RUBY
+    end
+
     it 'registers multiple offenses' do
       expect_offense(<<~RUBY)
         for n in [1, 2, 3] do

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+* [#12773](https://github.com/rubocop/rubocop/pull/12773): Fix an error for `Style/For` with `EnforcedStyle: for` when no receiver. ([@earlopain][])