Merge pull request #14196 from viralpraxis/consistent-metric-dep-cops-method-names-highlight

koic · web-flow · commit c7040a7293b3 · 2025-05-22T00:12:48.000+09:00
Consistently highlight `Metric` cops method name in offense messages
diff --git a/lib/rubocop/cop/metrics/abc_size.rb b/lib/rubocop/cop/metrics/abc_size.rb
@@ -39,7 +39,7 @@ module Metrics
       class AbcSize < Base
         include MethodComplexity
 
-        MSG = 'Assignment Branch Condition size for %<method>s is too high. ' \
+        MSG = 'Assignment Branch Condition size for `%<method>s` is too high. ' \
               '[%<abc_vector>s %<complexity>.4g/%<max>.4g]'
 
         private
diff --git a/spec/rubocop/cop/metrics/abc_size_spec.rb b/spec/rubocop/cop/metrics/abc_size_spec.rb
@@ -21,7 +21,7 @@ def method_name
     it 'registers an offense for an if modifier' do
       expect_offense(<<~RUBY)
         def method_name
-        ^^^^^^^^^^^^^^^ Assignment Branch Condition size for method_name is too high. [<0, 2, 1> 2.24/0]
+        ^^^^^^^^^^^^^^^ Assignment Branch Condition size for `method_name` is too high. [<0, 2, 1> 2.24/0]
           call_foo if some_condition # 0 + 2*2 + 1*1
         end
       RUBY
@@ -30,7 +30,7 @@ def method_name
     it 'registers an offense for an assignment of a local variable' do
       offenses = expect_offense(<<~RUBY)
         def method_name
-        ^^^^^^^^^^^^^^^ Assignment Branch Condition size for method_name is too high. [<1, 0, 0> 1/0]
+        ^^^^^^^^^^^^^^^ Assignment Branch Condition size for `method_name` is too high. [<1, 0, 0> 1/0]
           x = 1
         end
       RUBY
@@ -41,7 +41,7 @@ def method_name
     it 'registers an offense for an assignment of an element' do
       expect_offense(<<~RUBY)
         def method_name
-        ^^^^^^^^^^^^^^^ Assignment Branch Condition size for method_name is too high. [<1, 2, 0> 2.24/0]
+        ^^^^^^^^^^^^^^^ Assignment Branch Condition size for `method_name` is too high. [<1, 2, 0> 2.24/0]
           x[0] = 1
         end
       RUBY
@@ -50,7 +50,7 @@ def method_name
     it 'registers an offense for complex content including A, B, and C scores' do
       expect_offense(<<~RUBY)
         def method_name
-        ^^^^^^^^^^^^^^^ Assignment Branch Condition size for method_name is too high. [<3, 4, 5> 7.07/0]
+        ^^^^^^^^^^^^^^^ Assignment Branch Condition size for `method_name` is too high. [<3, 4, 5> 7.07/0]
           my_options = Hash.new if 1 == 1 || 2 == 2 # 1, 1, 4
           my_options.each do |key, value|           # 2, 1, 1
             p key                                   # 0, 1, 0
@@ -63,7 +63,7 @@ def method_name
     it 'registers an offense for a `define_method`' do
       expect_offense(<<~RUBY)
         define_method :method_name do
-        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Assignment Branch Condition size for method_name is too high. [<1, 0, 0> 1/0]
+        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Assignment Branch Condition size for `method_name` is too high. [<1, 0, 0> 1/0]
           x = 1
         end
       RUBY
@@ -73,7 +73,7 @@ def method_name
       it 'registers an offense for a `define_method` with numblock' do
         expect_offense(<<~RUBY)
           define_method :method_name do
-          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Assignment Branch Condition size for method_name is too high. [<1, 0, 0> 1/0]
+          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Assignment Branch Condition size for `method_name` is too high. [<1, 0, 0> 1/0]
             x = _1
           end
         RUBY
@@ -84,7 +84,7 @@ def method_name
       it 'registers an offense for a `define_method` with itblock' do
         expect_offense(<<~RUBY)
           define_method :method_name do
-          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Assignment Branch Condition size for method_name is too high. [<1, 0, 0> 1/0]
+          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Assignment Branch Condition size for `method_name` is too high. [<1, 0, 0> 1/0]
             x = it
           end
         RUBY
@@ -94,7 +94,7 @@ def method_name
     it 'treats safe navigation method calls like regular method calls + a condition' do
       expect_offense(<<~RUBY)
         def method_name
-        ^^^^^^^^^^^^^^^ Assignment Branch Condition size for method_name is too high. [<0, 2, 1> 2.24/0]
+        ^^^^^^^^^^^^^^^ Assignment Branch Condition size for `method_name` is too high. [<0, 2, 1> 2.24/0]
           object&.do_something
         end
       RUBY
@@ -104,7 +104,7 @@ def method_name
       it 'registers an offense for an assignment of a local variable' do
         offenses = expect_offense(<<~RUBY)
           def method_name
-          ^^^^^^^^^^^^^^^ Assignment Branch Condition size for method_name is too high. [<1, 0, 0> 1/0]
+          ^^^^^^^^^^^^^^^ Assignment Branch Condition size for `method_name` is too high. [<1, 0, 0> 1/0]
             x = 1
           end
         RUBY
@@ -177,7 +177,7 @@ def self.foo
       it 'does not count repeated attributes' do
         expect_offense(<<~RUBY)
           def foo
-          ^^^^^^^ Assignment Branch Condition size for foo is too high. [<0, 1, 0> 1/0]
+          ^^^^^^^ Assignment Branch Condition size for `foo` is too high. [<0, 1, 0> 1/0]
             bar
             self.bar
             bar
@@ -192,7 +192,7 @@ def foo
       it 'counts repeated attributes' do
         expect_offense(<<~RUBY)
           def foo
-          ^^^^^^^ Assignment Branch Condition size for foo is too high. [<0, 3, 0> 3/0]
+          ^^^^^^^ Assignment Branch Condition size for `foo` is too high. [<0, 3, 0> 3/0]
             bar
             self.bar
             bar
@@ -243,7 +243,7 @@ def method_name
 
         expect_offense(<<~RUBY)
           def method_name
-          ^^^^^^^^^^^^^^^ Assignment Branch Condition size for method_name is too high. [#{presentation}]
+          ^^^^^^^^^^^^^^^ Assignment Branch Condition size for `method_name` is too high. [#{presentation}]
             #{code.join("\n  ")}
           end
         RUBY
