Add Errno::EROFS exception handling for read-only file systems

Strzesia · Strzesia · commit d0dccdd71f75 · 2024-01-17T11:56:41.000+01:00
diff --git a/changelog/fix_errno_erofs.md b/changelog/fix_errno_erofs.md
@@ -0,0 +1 @@
+* [#12625](https://github.com/rubocop/rubocop/pull/12625): Fix an error when server cache dir has read-only file system. ([@Strzesia][])
diff --git a/lib/rubocop/server/cache.rb b/lib/rubocop/server/cache.rb
@@ -117,7 +117,7 @@ def stderr_path
 
         def pid_running?
           Process.kill(0, pid_path.read.to_i) == 1
-        rescue Errno::ESRCH, Errno::ENOENT, Errno::EACCES
+        rescue Errno::ESRCH, Errno::ENOENT, Errno::EACCES, Errno::EROFS
           false
         end
 
diff --git a/spec/rubocop/server/cache_spec.rb b/spec/rubocop/server/cache_spec.rb
@@ -292,6 +292,15 @@
         end
         expect(described_class.pid_running?).to be(false)
       end
+
+      it 'works properly when the file system is read-only' do
+        expect(described_class).to receive(:pid_path).and_wrap_original do |method|
+          result = method.call
+          allow(result).to receive(:read).and_raise(Errno::EROFS)
+          result
+        end
+        expect(described_class.pid_running?).to be(false)
+      end
     end
   end
 end

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+* [#12625](https://github.com/rubocop/rubocop/pull/12625): Fix an error when server cache dir has read-only file system. ([@Strzesia][])`