Allow TLS1_1 and TLS1_2 by default in Naming/VariableNumber

koic · bbatsov · commit f20e4c5f8d4f · 2025-03-12T07:12:04.000+02:00
This PR allows `TLS1_1` and `TLS1_2` by default in `Naming/VariableNumber`.
to accommodate OpenSSL version parameter names.
diff --git a/changelog/change_allow_tls_1_1_and_tls_1_2_in_naming_variable_number.md b/changelog/change_allow_tls_1_1_and_tls_1_2_in_naming_variable_number.md
@@ -0,0 +1 @@
+* [#13977](https://github.com/rubocop/rubocop/issues/13977): Allow `TLS1_1` and `TLS1_2` by default in `Naming/VariableNumber` to accommodate OpenSSL version parameter names. ([@koic][])
diff --git a/config/default.yml b/config/default.yml
@@ -3104,6 +3104,8 @@ Naming/VariableNumber:
   CheckMethodNames: true
   CheckSymbols: true
   AllowedIdentifiers:
+    - TLS1_1       # OpenSSL::SSL::TLS1_1_VERSION
+    - TLS1_2       # OpenSSL::SSL::TLS1_2_VERSION
     - capture3     # Open3.capture3
     - iso8601      # Time#iso8601
     - rfc1123_date # CGI.rfc1123_date
diff --git a/spec/rubocop/config_loader_spec.rb b/spec/rubocop/config_loader_spec.rb
@@ -746,7 +746,9 @@
           .to contain_exactly('foo.rb', 'test.rb')
         expect(examples_configuration['Include']).to contain_exactly('bar.rb', 'another_test.rb')
         expect(examples_configuration['AllowedIdentifiers'])
-          .to match_array(%w[capture3 iso8601 rfc1123_date rfc2822 rfc3339 rfc822 iso2 x86_64])
+          .to match_array(
+            %w[TLS1_1 TLS1_2 capture3 iso8601 rfc1123_date rfc2822 rfc3339 rfc822 iso2 x86_64]
+          )
         expect(examples_configuration['InheritedArraySpecifiedString']).to contain_exactly(
           'bare string',
           'string in array'

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+* [#13977](https://github.com/rubocop/rubocop/issues/13977): Allow `TLS1_1` and `TLS1_2` by default in `Naming/VariableNumber` to accommodate OpenSSL version parameter names. ([@koic][])