Merge pull request #373 from tagliala/bugfix/fix-target-ruby-version-of-unfreeze-string

koic · web-flow · commit 1b8df404b49d · 2023-09-17T03:16:24.000+09:00
Set target version for `Performance/UnfreezeString`
diff --git a/changelog/fix_target_version_for_unfreeze_string_cop.md b/changelog/fix_target_version_for_unfreeze_string_cop.md
@@ -0,0 +1 @@
+* [#373](https://github.com/rubocop/rubocop-performance/pull/373): Set target version for `Performance/UnfreezeString`. ([@tagliala][])
diff --git a/lib/rubocop/cop/performance/unfreeze_string.rb b/lib/rubocop/cop/performance/unfreeze_string.rb
@@ -26,6 +26,9 @@ module Performance
       #   +''
       class UnfreezeString < Base
         extend AutoCorrector
+        extend TargetRubyVersion
+
+        minimum_target_ruby_version 2.3
 
         MSG = 'Use unary plus to get an unfrozen string literal.'
         RESTRICT_ON_SEND = %i[dup new].freeze
diff --git a/spec/rubocop/cop/performance/unfreeze_string_spec.rb b/spec/rubocop/cop/performance/unfreeze_string_spec.rb
@@ -112,4 +112,12 @@
       String.new(capacity: 100)
     RUBY
   end
+
+  context 'when Ruby <= 2.2', :ruby22 do
+    it 'does not register an offense for an empty string with `.dup`' do
+      expect_no_offenses(<<~RUBY)
+        "".dup
+      RUBY
+    end
+  end
 end

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+* [#373](https://github.com/rubocop/rubocop-performance/pull/373): Set target version for `Performance/UnfreezeString`. ([@tagliala][])