Merge pull request #757 from rahim/fix-generator-error-no-method-error

byroot · web-flow · commit ac30b69c06a2 · 2025-03-05T22:05:26.000+01:00
Fix JSON::GeneratorError#detailed_message with Ruby &lt; 3.2
diff --git a/lib/json/common.rb b/lib/json/common.rb
@@ -152,10 +152,13 @@ def initialize(message, invalid_object = nil)
     end
 
     def detailed_message(...)
+      # Exception#detailed_message doesn't exist until Ruby 3.2
+      super_message = defined?(super) ? super : message
+
       if @invalid_object.nil?
-        super
+        super_message
       else
-        "#{super}\nInvalid object: #{@invalid_object.inspect}"
+        "#{super_message}\nInvalid object: #{@invalid_object.inspect}"
       end
     end
   end
diff --git a/test/json/json_generator_test.rb b/test/json/json_generator_test.rb
@@ -410,6 +410,14 @@ def test_json_generate
     end
   end
 
+  def test_json_generate_error_detailed_message
+    error = assert_raise JSON::GeneratorError do
+      generate(["\xea"])
+    end
+
+    assert_not_nil(error.detailed_message)
+  end
+
   def test_json_generate_unsupported_types
     assert_raise JSON::GeneratorError do
       generate(Object.new, strict: true)
