Fix custom marshalization with symbolize_names: true

byroot · byroot · commit ee26f26ab5e3 · 2021-02-15T10:18:46.000+01:00
diff --git a/lib/psych/visitors/to_ruby.rb b/lib/psych/visitors/to_ruby.rb
@@ -339,7 +339,7 @@ def register_empty object
         list
       end
 
-      def revive_hash hash, o
+      def revive_hash hash, o, tagged= false
         o.children.each_slice(2) { |k,v|
           key = accept(k)
           val = accept(v)
@@ -366,7 +366,7 @@ def revive_hash hash, o
               hash[key] = val
             end
           else
-            if @symbolize_names
+            if !tagged && @symbolize_names
               key = key.to_sym
             elsif !@freeze
               key = deduplicate(key)
@@ -404,7 +404,7 @@ def merge_key hash, key, val
 
       def revive klass, node
         s = register(node, klass.allocate)
-        init_with(s, revive_hash({}, node), node)
+        init_with(s, revive_hash({}, node, true), node)
       end
 
       def init_with o, h, node
diff --git a/test/psych/test_marshalable.rb b/test/psych/test_marshalable.rb
@@ -51,5 +51,13 @@ def test_init_with_takes_priority_over_marshal_methods
       assert(PsychCustomMarshalable === loaded)
       assert_equal(2, loaded.foo)
     end
+
+    def test_init_symbolize_names
+      obj = PsychCustomMarshalable.new(1)
+      loaded = Psych.load(Psych.dump(obj), symbolize_names: true)
+
+      assert(PsychCustomMarshalable === loaded)
+      assert_equal(2, loaded.foo)
+    end
   end
 end
