Raise an exception if it is specified together with other timeout options

shioimm · shioimm · commit 01ba74508663 · 2025-06-07T13:45:58.000+09:00
diff --git a/ext/socket/lib/socket.rb b/ext/socket/lib/socket.rb
@@ -657,6 +657,11 @@ def accept_nonblock(exception: true)
   #     puts sock.read
   #   }
   def self.tcp(host, port, local_host = nil, local_port = nil, connect_timeout: nil, resolv_timeout: nil, open_timeout: nil, fast_fallback: tcp_fast_fallback, &) # :yield: socket
+
+    if open_timeout && (connect_timeout || resolv_timeout)
+      raise ArgumentError, "Cannot specify open_timeout along with connect_timeout or resolv_timeout"
+    end
+
     sock = if fast_fallback && !(host && ip_address?(host))
       tcp_with_fast_fallback(host, port, local_host, local_port, connect_timeout:, resolv_timeout:, open_timeout:)
     else
diff --git a/test/socket/test_socket.rb b/test/socket/test_socket.rb
@@ -954,6 +954,15 @@ def test_tcp_socket_open_timeout
     RUBY
   end
 
+  def test_tcp_socket_open_timeout_with_other_timeouts
+    opts = %w[-rsocket -W1]
+    assert_separately opts, <<~RUBY
+    assert_raise(ArgumentError) do
+      Socket.tcp("localhost", 12345, open_timeout: 0.01, resolv_timout: 0.01)
+    end
+    RUBY
+  end
+
   def test_tcp_socket_one_hostname_resolution_succeeded_at_least
     opts = %w[-rsocket -W1]
     assert_separately opts, <<~RUBY
